lmccay commented on PR #504: URL: https://github.com/apache/incubator-livy/pull/504#issuecomment-3760901472
> > @edwardcapriolo - this contains non-docs related changes. Please break this up so that any required revert would be clean for the intended changes. > > The reason for this is nothing I do is getting merged so my master keeps accumulating "stuff". Is it fine otherwise? This is not a valid statement. Let's keep the issues separate, as I said, so that we can easily revert a code change without reverting a fix for docs being published. I don't have any context for reviewing the code changes that you have made there so can't really review it. Break them apart and provide context and manner of testing that was done and make sure it passes the precommits and we will be good to review it. Fixing the scala docs should be a no brainer review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
