ArnavBalyan commented on code in PR #523:
URL: https://github.com/apache/incubator-livy/pull/523#discussion_r3363791888
##########
server/src/main/scala/org/apache/livy/server/recovery/ZooKeeperManager.scala:
##########
@@ -63,6 +64,26 @@ class ZooKeeperManager(
"Correct format is <max retry count>,<sleep ms between retry>. e.g.
5,100")
}
+ private[recovery] def createZKClientConfig = {
+ val clientConfig = new ZKClientConfig
Review Comment:
nit: when secure is true, can we strict require() the four SSL fields
(truststore location/password, ssl keystore, keystore password) since operator
missing out on some configs would cause retry loop to zk connection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
