nileshrathi345 commented on code in PR #529:
URL: https://github.com/apache/livy/pull/529#discussion_r3472208270
##########
server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala:
##########
@@ -40,6 +40,7 @@ case class BatchRecoveryMetadata(
appTag: String,
owner: String,
proxyUser: Option[String],
+ queue: Option[String],
Review Comment:
Thanks for the clarification. Agreed that persisting queue in
BatchRecoveryMetadata is out of scope for LIVY-1059.
The reason queue appears in recover() is purely a constructor consistency
concern — since BatchSession now accepts queue as a constructor parameter
(added in create() to store the resolved value for the lifetime of the
session), recover() must also pass a value to satisfy that constructor. In this
case, can now pass **None** OR explicitly, meaning no queue is stored or
exposed for recovered sessions, which aligns with point that recovery does not
need to know or show the original queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
