nileshrathi345 commented on code in PR #533:
URL: https://github.com/apache/livy/pull/533#discussion_r3662731238
##########
server/src/test/scala/org/apache/livy/utils/SparkYarnAppSpec.scala:
##########
@@ -49,6 +50,13 @@ class SparkYarnAppSpec extends FunSpec with
LivyBaseUnitTestSuite {
Thread.`yield`()
}
+ private def mockGetApplicationsByTags(
+ client: YarnClient,
+ reports: List[ApplicationReport]): Unit = {
+ when(client.getApplications(any(classOf[GetApplicationsRequest])))
Review Comment:
Stronger tests with ArgumentCaptor — added
verifyFilteredGetApplicationsRequest() to assert:
- Request includes expected tags (lowercase)
- Request filters by SPARK application type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
