Repository: incubator-livy Updated Branches: refs/heads/master dddb29b5d -> 1d05d18cf
[LIVY-539] Fix incorrect default value in livy-client.conf.template ## What changes were proposed in this pull request? JIRA LINK: https://issues.apache.org/jira/browse/LIVY-539 The template for `livy-client.conf` implies that the default value of `livy.rsc.launcher.port.range` is `10000~10110`, but this is in fact incorrect - the real default value is `10000~10010`, as you can [see here](https://github.com/apache/incubator-livy/blob/master/rsc/src/main/java/org/apache/livy/rsc/RSCConf.java#L54). This is really confusing, especially since: * 10110 is wrong on the Spark side, the default configuration there won't open that many ports * 10010 and 10110 look very similar to the human eye so it can take a long time to notice the discrepancy This PR modifies the default conf template to reflect the real default value. ## How was this patch tested? No testing applicable, it's a configuration template fix. Author: Adrian Petrescu <apetr...@gmail.com> Closes #132 from apetresc/patch-1. Project: http://git-wip-us.apache.org/repos/asf/incubator-livy/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-livy/commit/1d05d18c Tree: http://git-wip-us.apache.org/repos/asf/incubator-livy/tree/1d05d18c Diff: http://git-wip-us.apache.org/repos/asf/incubator-livy/diff/1d05d18c Branch: refs/heads/master Commit: 1d05d18cf037121722750504050195249616019f Parents: dddb29b Author: Adrian Petrescu <apetr...@gmail.com> Authored: Tue Dec 4 14:36:49 2018 -0800 Committer: Marcelo Vanzin <van...@cloudera.com> Committed: Tue Dec 4 14:36:49 2018 -0800 ---------------------------------------------------------------------- conf/livy-client.conf.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-livy/blob/1d05d18c/conf/livy-client.conf.template ---------------------------------------------------------------------- diff --git a/conf/livy-client.conf.template b/conf/livy-client.conf.template index 1737124..30a73f7 100644 --- a/conf/livy-client.conf.template +++ b/conf/livy-client.conf.template @@ -73,7 +73,7 @@ # Address for the RSC driver to connect back with it's connection info. # livy.rsc.launcher.address = # Port Range on which RPC will launch . Port range in inclusive of start and end port . -# livy.rsc.launcher.port.range = 10000~10110 +# livy.rsc.launcher.port.range = 10000~10010 # How long will the RSC wait for a connection for a Livy server before shutting itself down. # livy.rsc.server.idle-timeout = 10m
