Author: ihabunek
Date: Thu Mar 29 15:04:20 2012
New Revision: 1306892

URL: http://svn.apache.org/viewvc?rev=1306892&view=rev
Log:
LOG4PHP-174: 
* Using integer level constants for switching instead of strings.
* Removed call to console->debug() because the method does not exist.
* Removed call to console->trace() because it is not used for trace-level 
logging, but for outputting the call trace.

Modified:
    logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php

Modified: logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php
URL: 
http://svn.apache.org/viewvc/logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php?rev=1306892&r1=1306891&r2=1306892&view=diff
==============================================================================
--- logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php 
(original)
+++ logging/log4php/trunk/src/main/php/appenders/LoggerAppenderFirephp.php Thu 
Mar 29 15:04:20 2012
@@ -75,28 +75,24 @@ class LoggerAppenderFirephp extends Logg
        public function append(LoggerLoggingEvent $event) {
                $msg = $this->getLayout()->format($event);
                
-               switch ($this->getLogLevel($event)) {
-               case 'debug':
-                       $this->console->trace($msg);    //includes backtrace
-                       break;
-               case 'warn':
-                       $this->console->debug($msg);
-                       break;
-               case 'error':
-                       $this->console->warn($msg);
-                       break;
-               case 'fatal':
-                       $this->console->error($msg);
-                       break;
-               default:
-                       $this->console->info($msg);
+               switch ($event->getLevel()->toInt()) {
+                       case LoggerLevel::TRACE:
+                       case LoggerLevel::DEBUG:
+                               $this->console->log($msg);
+                               break;
+                       case LoggerLevel::INFO:
+                               $this->console->info($msg);
+                               break;
+                       case LoggerLevel::WARN:
+                               $this->console->warn($msg);
+                               break;
+                       case LoggerLevel::ERROR:
+                       case LoggerLevel::FATAL:
+                               $this->console->error($msg);
+                               break;
                }
        }
        
-       private function getLogLevel(LoggerLoggingEvent $event) {
-               return strtolower($event->getLevel()->toString());
-       }
-
        /** Returns the target. */
        public function getTarget() {
                return $this->target;


Reply via email to