Author: ggregory
Date: Mon May 12 16:17:05 2014
New Revision: 1594019
URL: http://svn.apache.org/r1594019
Log:
Extract magic char as a constant.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
URL:
http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java?rev=1594019&r1=1594018&r2=1594019&view=diff
==============================================================================
---
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
(original)
+++
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
Mon May 12 16:17:05 2014
@@ -34,6 +34,8 @@ import org.apache.logging.log4j.status.S
*/
public class ThrowableProxy implements Serializable {
+ private static final char EOL = '\n';
+
private static final long serialVersionUID = -2752771578252251910L;
private static final Logger LOGGER = StatusLogger.getLogger();
@@ -178,7 +180,7 @@ public class ThrowableProxy implements S
sb.append("Wrapped by: ");
}
sb.append(toString());
- sb.append('\n');
+ sb.append(EOL);
formatElements(sb, 0, throwable.getStackTrace(), callerPackageData,
packages);
return sb.toString();
}
@@ -205,7 +207,7 @@ public class ThrowableProxy implements S
formatWrapper(sb, cause.proxyCause);
sb.append("Wrapped by: ");
}
- sb.append(cause).append('\n');
+ sb.append(cause).append(EOL);
formatElements(sb, cause.commonElementCount,
cause.getThrowable().getStackTrace(), cause.callerPackageData,
packages);
}
@@ -229,7 +231,7 @@ public class ThrowableProxy implements S
if (msg != null) {
sb.append(": ").append(throwable.getMessage());
}
- sb.append('\n');
+ sb.append(EOL);
formatElements(sb, 0, throwable.getStackTrace(), callerPackageData,
packages);
if (proxyCause != null) {
formatCause(sb, proxyCause, packages);
@@ -255,7 +257,7 @@ public class ThrowableProxy implements S
@SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void formatCause(final StringBuilder sb, final ThrowableProxy
cause, final List<String> packages) {
- sb.append("Caused by: ").append(cause).append('\n');
+ sb.append("Caused by: ").append(cause).append(EOL);
formatElements(sb, cause.commonElementCount,
cause.getThrowable().getStackTrace(), cause.callerPackageData,
packages);
if (cause.getCause() != null) {
@@ -295,7 +297,7 @@ public class ThrowableProxy implements S
}
}
if (commonCount != 0) {
- sb.append("\t... ").append(commonCount).append("
more").append('\n');
+ sb.append("\t... ").append(commonCount).append("
more").append(EOL);
}
}
@@ -305,7 +307,7 @@ public class ThrowableProxy implements S
sb.append(element);
sb.append(' ');
sb.append(packageData);
- sb.append('\n');
+ sb.append(EOL);
}
private boolean isSuppressed(final StackTraceElement element, final
List<String> packages) {
