Author: mattsicker
Date: Mon May 26 19:30:56 2014
New Revision: 1597632
URL: http://svn.apache.org/r1597632
Log:
Add some todo comments.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/TypeConverters.java
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/TypeConverters.java
URL:
http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/TypeConverters.java?rev=1597632&r1=1597631&r2=1597632&view=diff
==============================================================================
---
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/TypeConverters.java
(original)
+++
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/TypeConverters.java
Mon May 26 19:30:56 2014
@@ -38,6 +38,8 @@ import org.apache.logging.log4j.util.Eng
*/
public final class TypeConverters {
+ // TODO: this could probably be combined with the usual plugin
architecture instead
+
private static final Logger LOGGER = StatusLogger.getLogger();
private final Map<Class<?>, TypeConverter<?>> registry =
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java
URL:
http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java?rev=1597632&r1=1597631&r2=1597632&view=diff
==============================================================================
---
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java
(original)
+++
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/visitors/PluginVisitors.java
Mon May 26 19:30:56 2014
@@ -43,6 +43,7 @@ public final class PluginVisitors {
static {
// register the default PluginVisitor classes
+ // TODO: this could probably be combined with the usual plugin
architecture instead
REGISTRY = new ConcurrentHashMap<Class<? extends Annotation>, Class<?
extends PluginVisitor<? extends Annotation>>>();
registerVisitor(PluginAttribute.class, PluginAttributeVisitor.class);
registerVisitor(SensitivePluginAttribute.class,
SensitivePluginAttributeVisitor.class);
