Author: ggregory
Date: Sat May 31 05:22:17 2014
New Revision: 1598816

URL: http://svn.apache.org/r1598816
Log:
Fix DatagramOutputStream leak when an error occurs.

Modified:
    
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/net/DatagramSocketManager.java

Modified: 
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/net/DatagramSocketManager.java
URL: 
http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/net/DatagramSocketManager.java?rev=1598816&r1=1598815&r2=1598816&view=diff
==============================================================================
--- 
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/net/DatagramSocketManager.java
 (original)
+++ 
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/net/DatagramSocketManager.java
 Sat May 31 05:22:17 2014
@@ -105,14 +105,14 @@ public class DatagramSocketManager exten
         @Override
         public DatagramSocketManager createManager(final String name, final 
FactoryData data) {
             InetAddress inetAddress;
-            final OutputStream os = new DatagramOutputStream(data.host, 
data.port, data.layout.getHeader(),
-                data.layout.getFooter());
             try {
                 inetAddress = InetAddress.getByName(data.host);
             } catch (final UnknownHostException ex) {
                 LOGGER.error("Could not find address of " + data.host, ex);
                 return null;
             }
+            final OutputStream os = new DatagramOutputStream(data.host, 
data.port, data.layout.getHeader(),
+                    data.layout.getFooter());
             return new DatagramSocketManager(name, os, inetAddress, data.host, 
data.port, data.layout);
         }
     }


Reply via email to