Repository: logging-log4j2 Updated Branches: refs/heads/master df71c934d -> 33d3e7151
Refactor duplicate code into a method. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/33d3e715 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/33d3e715 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/33d3e715 Branch: refs/heads/master Commit: 33d3e7151fc91e195f2050f79c4bc125f9e70c3d Parents: df71c93 Author: Gary Gregory <[email protected]> Authored: Tue Dec 2 13:18:31 2014 -0500 Committer: Gary Gregory <[email protected]> Committed: Tue Dec 2 13:18:31 2014 -0500 ---------------------------------------------------------------------- .../logging/log4j/core/impl/ThrowableProxy.java | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/33d3e715/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java index 23065ab..1444c30 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java @@ -203,11 +203,7 @@ public class ThrowableProxy implements Serializable { for (int i = 0; i < extStackTrace.length; ++i) { if (!this.ignoreElement(causedTrace[i], ignorePackages)) { if (count > 0) { - if (count == 1) { - sb.append("\t....\n"); - } else { - sb.append("\t... suppressed ").append(count).append(" lines\n"); - } + appendSuppressedCount(sb, count); count = 0; } this.formatEntry(extStackTrace[i], sb); @@ -216,11 +212,7 @@ public class ThrowableProxy implements Serializable { } } if (count > 0) { - if (count == 1) { - sb.append("\t...\n"); - } else { - sb.append("\t... suppressed ").append(count).append(" lines\n"); - } + appendSuppressedCount(sb, count); } } if (commonCount != 0) { @@ -228,6 +220,14 @@ public class ThrowableProxy implements Serializable { } } + private void appendSuppressedCount(final StringBuilder sb, int count) { + if (count == 1) { + sb.append("\t....\n"); + } else { + sb.append("\t... suppressed ").append(count).append(" lines\n"); + } + } + private void formatEntry(final ExtendedStackTraceElement extStackTraceElement, final StringBuilder sb) { sb.append("\tat "); sb.append(extStackTraceElement);
