Repository: logging-log4j2 Updated Branches: refs/heads/master 3fdd73936 -> 6401ee459
Reuse the Integer object cache in tests. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/6401ee45 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/6401ee45 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/6401ee45 Branch: refs/heads/master Commit: 6401ee4595c5cf2543a3baa638317dae884c3c51 Parents: 3fdd739 Author: Gary Gregory <[email protected]> Authored: Thu Mar 5 09:27:17 2015 -0800 Committer: Gary Gregory <[email protected]> Committed: Thu Mar 5 09:27:17 2015 -0800 ---------------------------------------------------------------------- .../test/java/org/apache/logging/log4j/LoggerTest.java | 2 +- .../logging/log4j/FilterPerformanceComparison.java | 4 ++-- .../org/apache/logging/log4j/PerformanceComparison.java | 12 ++++++------ .../java/org/apache/logging/log4j/PerformanceRun.java | 6 +++--- .../logging/log4j/core/pattern/PatternParserTest2.java | 2 +- .../logging/log4j/perf/jmh/DebugDisabledBenchmark.java | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6401ee45/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java b/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java index 201a051..1231f85 100644 --- a/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java +++ b/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java @@ -321,7 +321,7 @@ public class LoggerTest { @Test public void mdc() { - ThreadContext.put("TestYear", new Integer(2010).toString()); + ThreadContext.put("TestYear", Integer.valueOf(2010).toString()); logger.debug("Debug message"); ThreadContext.clearMap(); logger.debug("Debug message"); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6401ee45/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java b/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java index a433f08..9147e30 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java @@ -113,7 +113,7 @@ public class FilterPerformanceComparison { } private long logback(final int loop) { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { logbacklogger.debug("SEE IF THIS IS LOGGED {}.", j); @@ -123,7 +123,7 @@ public class FilterPerformanceComparison { private long log4j2(final int loop) { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { logger.debug("SEE IF THIS IS LOGGED {}.", j); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6401ee45/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceComparison.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceComparison.java b/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceComparison.java index 87aa3af..b38955a 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceComparison.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceComparison.java @@ -124,7 +124,7 @@ public class PerformanceComparison { } private long log4j(final int loop) { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { log4jlogger.debug("SEE IF THIS IS LOGGED " + j + '.'); @@ -133,7 +133,7 @@ public class PerformanceComparison { } private long logback(final int loop) { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { logbacklogger.debug("SEE IF THIS IS LOGGED " + j + '.'); @@ -143,7 +143,7 @@ public class PerformanceComparison { private long log4j2(final int loop) { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { logger.debug("SEE IF THIS IS LOGGED " + j + '.'); @@ -153,7 +153,7 @@ public class PerformanceComparison { private long writeToWriter(final int loop, final Writer w) throws Exception { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { w.write("SEE IF THIS IS LOGGED " + j + '.'); @@ -162,7 +162,7 @@ public class PerformanceComparison { } private long writeToStream(final int loop, final OutputStream os) throws Exception { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { os.write(getBytes("SEE IF THIS IS LOGGED " + j + '.')); @@ -171,7 +171,7 @@ public class PerformanceComparison { } private long writeToChannel(final int loop, final FileChannel channel) throws Exception { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final ByteBuffer buf = ByteBuffer.allocateDirect(8*1024); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6401ee45/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceRun.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceRun.java b/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceRun.java index ea48f9b..76e191e 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceRun.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/PerformanceRun.java @@ -95,7 +95,7 @@ public class PerformanceRun { } private long writeToWriter(final int loop, final Writer w) throws Exception { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { w.write("SEE IF THIS IS LOGGED " + j + '.'); @@ -104,7 +104,7 @@ public class PerformanceRun { } private long writeToStream(final int loop, final OutputStream os) throws Exception { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { os.write(getBytes("SEE IF THIS IS LOGGED " + j + '.')); @@ -113,7 +113,7 @@ public class PerformanceRun { } private long writeToChannel(final int loop, final FileChannel channel) throws Exception { - final Integer j = new Integer(2); + final Integer j = Integer.valueOf(2); final ByteBuffer buf = ByteBuffer.allocateDirect(8 * 1024); final long start = System.nanoTime(); for (int i = 0; i < loop; i++) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6401ee45/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java index 44e3e47..3d1e47e 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/PatternParserTest2.java @@ -55,7 +55,7 @@ public class PatternParserTest2 { cal.set(Calendar.HOUR_OF_DAY, 13); cal.set(Calendar.MINUTE, 24); cal.set(Calendar.SECOND, 59); - parse(pattern, convert, buf, cal.getTime(), new Integer(3)); + parse(pattern, convert, buf, cal.getTime(), 3); assertEquals("13-24-59 \\t---", buf.toString()); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6401ee45/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/DebugDisabledBenchmark.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/DebugDisabledBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/DebugDisabledBenchmark.java index 45138b8..0152a9b 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/DebugDisabledBenchmark.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/DebugDisabledBenchmark.java @@ -50,7 +50,7 @@ public class DebugDisabledBenchmark { log4jLogger = LogManager.getLogger(DebugDisabledBenchmark.class); slf4jLogger = LoggerFactory.getLogger(DebugDisabledBenchmark.class); log4jClassicLogger = org.apache.log4j.Logger.getLogger(DebugDisabledBenchmark.class); - j = new Integer(2); + j = Integer.valueOf(2); } @TearDown
