Less type-casting in org.apache.log4j.LogManager internals. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/12c727d1 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/12c727d1 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/12c727d1
Branch: refs/heads/master Commit: 12c727d1d368f1bd5287af624631d5a33456c2b0 Parents: 077d02a Author: ggregory <[email protected]> Authored: Sun Aug 9 12:57:24 2015 -0700 Committer: ggregory <[email protected]> Committed: Sun Aug 9 12:57:24 2015 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/log4j/LogManager.java | 23 ++++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/12c727d1/log4j-1.2-api/src/main/java/org/apache/log4j/LogManager.java ---------------------------------------------------------------------- diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/LogManager.java b/log4j-1.2-api/src/main/java/org/apache/log4j/LogManager.java index c446954..b36eaea 100644 --- a/log4j-1.2-api/src/main/java/org/apache/log4j/LogManager.java +++ b/log4j-1.2-api/src/main/java/org/apache/log4j/LogManager.java @@ -67,23 +67,23 @@ public final class LogManager { } public static Logger getRootLogger() { - return (Logger) Category.getInstance((LoggerContext) PrivateManager.getContext(), Strings.EMPTY); + return (Logger) Category.getInstance(PrivateManager.getContext(), Strings.EMPTY); } public static Logger getLogger(final String name) { - return (Logger) Category.getInstance((LoggerContext) PrivateManager.getContext(), name); + return (Logger) Category.getInstance(PrivateManager.getContext(), name); } public static Logger getLogger(@SuppressWarnings("rawtypes") final Class clazz) { - return (Logger) Category.getInstance((LoggerContext) PrivateManager.getContext(), clazz.getName()); + return (Logger) Category.getInstance(PrivateManager.getContext(), clazz.getName()); } public static Logger getLogger(final String name, final LoggerFactory factory) { - return (Logger) Category.getInstance((LoggerContext) PrivateManager.getContext(), name); + return (Logger) Category.getInstance(PrivateManager.getContext(), name); } public static Logger exists(final String name) { - final LoggerContext ctx = (LoggerContext) PrivateManager.getContext(); + final LoggerContext ctx = PrivateManager.getContext(); if (!ctx.hasLogger(name)) { return null; } @@ -96,7 +96,7 @@ public final class LogManager { } static void reconfigure() { - final LoggerContext ctx = (LoggerContext) PrivateManager.getContext(); + final LoggerContext ctx = PrivateManager.getContext(); ctx.reconfigure(); } @@ -162,17 +162,17 @@ public final class LogManager { @Override public Logger getLogger(final String name) { - return (Logger) Category.getInstance((LoggerContext) PrivateManager.getContext(), name); + return (Logger) Category.getInstance(PrivateManager.getContext(), name); } @Override public Logger getLogger(final String name, final LoggerFactory factory) { - return (Logger) Category.getInstance((LoggerContext) PrivateManager.getContext(), name); + return (Logger) Category.getInstance(PrivateManager.getContext(), name); } @Override public Logger getRootLogger() { - return (Logger) Category.getRoot((LoggerContext) PrivateManager.getContext()); + return (Logger) Category.getRoot(PrivateManager.getContext()); } @Override @@ -211,9 +211,8 @@ public final class LogManager { private static class PrivateManager extends org.apache.logging.log4j.LogManager { private static final String FQCN = LogManager.class.getName(); - - public static org.apache.logging.log4j.spi.LoggerContext getContext() { - return getContext(FQCN, false); + public static LoggerContext getContext() { + return (LoggerContext) getContext(FQCN, false); } public static org.apache.logging.log4j.Logger getLogger(final String name) {
