Repository: logging-log4j2 Updated Branches: refs/heads/master a8d901d91 -> f1821fc60
Use ternary expression instead of if-else. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/f1821fc6 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/f1821fc6 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/f1821fc6 Branch: refs/heads/master Commit: f1821fc605b70562907a59e2cc3ef0c1792e5f06 Parents: a8d901d Author: ggregory <[email protected]> Authored: Sun Aug 9 17:36:17 2015 -0700 Committer: ggregory <[email protected]> Committed: Sun Aug 9 17:36:17 2015 -0700 ---------------------------------------------------------------------- .../logging/log4j/core/appender/rewrite/MapRewritePolicy.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/f1821fc6/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/MapRewritePolicy.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/MapRewritePolicy.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/MapRewritePolicy.java index 7377b2c..cc115ea 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/MapRewritePolicy.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/MapRewritePolicy.java @@ -124,12 +124,7 @@ public final class MapRewritePolicy implements RewritePolicy { public static MapRewritePolicy createPolicy( @PluginAttribute("mode") final String mode, @PluginElement("KeyValuePair") final KeyValuePair[] pairs) { - Mode op; - if (mode == null) { - op = Mode.Add; - } else { - op = Mode.valueOf(mode); - } + Mode op = mode == null ? op = Mode.Add : Mode.valueOf(mode); if (pairs == null || pairs.length == 0) { LOGGER.error("keys and values must be specified for the MapRewritePolicy"); return null;
