Refactor common pattern into a new method. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/4001a30c Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/4001a30c Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/4001a30c
Branch: refs/heads/master Commit: 4001a30cf2c851f411cc3cc6fa813734351e9601 Parents: c4e780e Author: ggregory <[email protected]> Authored: Tue Sep 1 14:16:03 2015 -0700 Committer: ggregory <[email protected]> Committed: Tue Sep 1 14:16:03 2015 -0700 ---------------------------------------------------------------------- .../impl/DefaultConfigurationBuilder.java | 23 +++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/4001a30c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java index dc14647..8d023d4 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java @@ -86,32 +86,30 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement loggers = new Component("Loggers"); components.add(loggers); } + + protected ConfigurationBuilder<T> add(Component parent, ComponentBuilder<?> builder) { + parent.getComponents().add(builder.build()); + return this; + } @Override - @SuppressWarnings("unchecked") public ConfigurationBuilder<T> add(AppenderComponentBuilder builder) { - appenders.getComponents().add(builder.build()); - return this; + return add(appenders, builder); } @Override public ConfigurationBuilder<T> add(CustomLevelComponentBuilder builder) { - customLevels.getComponents().add(builder.build()); - return this; + return add(customLevels, builder); } @Override - @SuppressWarnings("unchecked") public ConfigurationBuilder<T> add(FilterComponentBuilder builder) { - filters.getComponents().add(builder.build()); - return this; + return add(filters, builder); } @Override - @SuppressWarnings("unchecked") public ConfigurationBuilder<T> add(LoggerComponentBuilder builder) { - loggers.getComponents().add(builder.build()); - return this; + return add(loggers, builder); } @Override @@ -122,8 +120,7 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement throw new ConfigurationException("root Logger was previously defined"); } } - loggers.getComponents().add(builder.build()); - return this; + return add(loggers, builder); } @Override
