Minor speed up: index the param array instead of streaming over it.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/7b4a51bf Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/7b4a51bf Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/7b4a51bf Branch: refs/heads/LOG4J2-1136 Commit: 7b4a51bf97451b90067437b44e48634ac611ea2c Parents: 4d57bbf Author: ggregory <[email protected]> Authored: Thu Sep 24 16:44:22 2015 -0700 Committer: Ralph Goers <[email protected]> Committed: Sun Sep 27 10:49:28 2015 -0700 ---------------------------------------------------------------------- .../org/apache/logging/log4j/spi/AbstractLogger.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/7b4a51bf/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java index a86017f..dea99c7 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java @@ -321,14 +321,10 @@ public abstract class AbstractLogger implements ExtendedLogger, Serializable { return messageFactory.newMessage("entry"); } final StringBuilder sb = new StringBuilder("entry params("); - int i = 0; - for (final Object parm : params) { - if (parm != null) { - sb.append(parm.toString()); - } else { - sb.append("null"); - } - if (++i < params.length) { + for (int i = 0; i < params.length; i++) { + Object parm = params[i]; + sb.append(parm != null ? parm.toString() : "null"); + if (i + 1 < params.length) { sb.append(", "); } }
