Redundant null check: The variable options cannot be null at this location.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/7b72ade3 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/7b72ade3 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/7b72ade3 Branch: refs/heads/LOG4J2-1136 Commit: 7b72ade3127a46015e9ab2e3671f9087efac6574 Parents: 523122d Author: ggregory <[email protected]> Authored: Thu Oct 1 14:21:34 2015 -0700 Committer: Ralph Goers <[email protected]> Committed: Sat Oct 3 23:08:05 2015 -0700 ---------------------------------------------------------------------- .../apache/logging/log4j/core/pattern/DatePatternConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/7b72ade3/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java index b7c4cd6..ce7b8ef 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java @@ -168,7 +168,7 @@ public final class DatePatternConverter extends LogEventPatternConverter impleme // if the option list contains a TZ option, then set it. TimeZone tz = null; - if (options != null && options.length > 1) { + if (options.length > 1) { tz = TimeZone.getTimeZone(options[1]); }
