LOG4J2-435 test delete does not exceed maxDepth even IfFileName glob condition matches nested file
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/ce588bbe Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/ce588bbe Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/ce588bbe Branch: refs/heads/master Commit: ce588bbed519c2466109dafaa670104b528b48e3 Parents: 0e8c438 Author: rpopma <[email protected]> Authored: Fri Nov 27 13:33:45 2015 +0900 Committer: rpopma <[email protected]> Committed: Fri Nov 27 13:33:45 2015 +0900 ---------------------------------------------------------------------- .../RollingAppenderDeleteMaxDepthTest.java | 118 +++++++++++++++++++ ...og4j-rolling-with-custom-delete-maxdepth.xml | 47 ++++++++ 2 files changed, 165 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ce588bbe/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDeleteMaxDepthTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDeleteMaxDepthTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDeleteMaxDepthTest.java new file mode 100644 index 0000000..62ff7ba --- /dev/null +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDeleteMaxDepthTest.java @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache license, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the license for the specific language governing permissions and + * limitations under the license. + */ +package org.apache.logging.log4j.core.appender.rolling; + +import java.io.BufferedWriter; +import java.io.File; +import java.io.IOException; +import java.nio.charset.Charset; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Arrays; +import java.util.regex.Pattern; + +import org.apache.logging.log4j.Logger; +import org.apache.logging.log4j.junit.LoggerContextRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExternalResource; +import org.junit.rules.RuleChain; + +import static org.junit.Assert.*; + +/** + * + */ +public class RollingAppenderDeleteMaxDepthTest { + + private static final String CONFIG = "log4j-rolling-with-custom-delete-maxdepth.xml"; + private static final String DIR = "target/rolling-with-delete-depth/test"; + + private final LoggerContextRule ctx = new LoggerContextRule(CONFIG); + + @Rule + public RuleChain chain = RuleChain.outerRule(new ExternalResource() { + @Override + protected void before() throws Throwable { + deleteDir(); + } + }).around(ctx); + + @Test + public void testAppender() throws Exception { + // create some files that match the glob but exceed maxDepth + Path p1 = writeTextTo(DIR + "/1/test-4.log"); // glob="**/test-4.log" + Path p2 = writeTextTo(DIR + "/2/test-4.log"); + Path p3 = writeTextTo(DIR + "/1/2/test-4.log"); + Path p4 = writeTextTo(DIR + "/1/2/3/test-4.log"); + + final Logger logger = ctx.getLogger(); + for (int i = 0; i < 10; ++i) { + // 30 chars per message: each message triggers a rollover + logger.debug("This is a test message number " + i); // 30 chars: + } + Thread.sleep(100); // Allow time for rollover to complete + + final File dir = new File(DIR); + assertTrue("Dir " + DIR + " should exist", dir.exists()); + assertTrue("Dir " + DIR + " should contain files", dir.listFiles().length > 0); + + final File[] files = dir.listFiles(); + assertEquals(Arrays.toString(files), 5, files.length); + for (File file : files) { + assertTrue("test-4.log should have been deleted", + Arrays.asList("1", "2", "test-1.log", "test-2.log", "test-3.log").contains(file.getName())); + } + + assertTrue(p1 + " should not have been deleted", Files.exists(p1)); + assertTrue(p2 + " should not have been deleted", Files.exists(p2)); + assertTrue(p3 + " should not have been deleted", Files.exists(p3)); + assertTrue(p4 + " should not have been deleted", Files.exists(p4)); + } + + private Path writeTextTo(String location) throws IOException { + Path path = Paths.get(location); + Files.createDirectories(path.getParent()); + try (BufferedWriter buffy = Files.newBufferedWriter(path, Charset.defaultCharset())) { + buffy.write("some text"); + buffy.newLine(); + buffy.flush(); + } + return path; + } + + private static void deleteDir() { + final File dir = new File(DIR); + if (dir.exists()) { + final File[] files = dir.listFiles(); + for (final File file : files) { + file.delete(); + } + dir.delete(); + } + } + + public static void main(String[] args) { + Pattern p = Pattern.compile("test-.?[2,4,6,8,0]\\.log\\.gz"); + for (int i = 0; i < 16; i++) { + String str = "test-" + i + ".log.gz"; + java.util.regex.Matcher m = p.matcher(str); + System.out.println(m.matches() + ": " + str); + } + } +} http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ce588bbe/log4j-core/src/test/resources/log4j-rolling-with-custom-delete-maxdepth.xml ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/resources/log4j-rolling-with-custom-delete-maxdepth.xml b/log4j-core/src/test/resources/log4j-rolling-with-custom-delete-maxdepth.xml new file mode 100644 index 0000000..3f750ba --- /dev/null +++ b/log4j-core/src/test/resources/log4j-rolling-with-custom-delete-maxdepth.xml @@ -0,0 +1,47 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<Configuration status="TRACE" name="RollingWithCustomDeleteTest"> + <Properties> + <Property name="base">target/rolling-with-delete-depth/</Property> + </Properties> + + <Appenders> + <RollingFile name="RollingFile" fileName="${base}/rollingtest.log" + filePattern="${base}/test/test-%i.log"> + <PatternLayout> + <Pattern>%d %p %c{1.} [%t] %m%n</Pattern> + </PatternLayout> + <Policies> + <SizeBasedTriggeringPolicy size="50" /> + </Policies> + <DefaultRolloverStrategy max="100" stopCustomActionsOnError="true"> + <Delete basePath="${base}" maxDepth="2" followLinks="false"> + <IfFileName glob="**/test-4.log" /> <!-- only keep files 1, 2 and 3 --> + </Delete> + </DefaultRolloverStrategy> + </RollingFile> + </Appenders> + + <Loggers> + <Root level="trace"> + <AppenderRef ref="RollingFile" /> + </Root> + </Loggers> + +</Configuration> \ No newline at end of file
