LOG4J2-1274 remove TODO items from Layout that requested functionality which was implemented in this ticket
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/7c4491c3 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/7c4491c3 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/7c4491c3 Branch: refs/heads/LOG4J2-1278-gc-free-logger Commit: 7c4491c3ccca5fbf38b6a7ee1e54be8677e8c6eb Parents: 4cf5e5b Author: rpopma <[email protected]> Authored: Sun Feb 21 23:04:02 2016 +0900 Committer: rpopma <[email protected]> Committed: Sun Feb 21 23:04:02 2016 +0900 ---------------------------------------------------------------------- .../src/main/java/org/apache/logging/log4j/core/Layout.java | 5 ----- 1 file changed, 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/7c4491c3/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java index 0a8a007..6385183 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java @@ -70,14 +70,9 @@ public interface Layout<T extends Serializable> extends Encoder<LogEvent> { * * @param event The Logging Event. * @return The formatted event. - * TODO Likely better to write to a OutputStream instead of return a byte[]. (RG) That limits how the - * Appender can use the Layout. For example, it might concatenate information in front or behind the - * data and then write it all to the OutputStream in one call. */ byte[] toByteArray(LogEvent event); - // TODO: it would be nice to provide ByteBuffers alongside the byte[]s - /** * Formats the event as an Object that can be serialized. *
