LOG4J2-1296 ReusableParameterizedMessageFactory small refactoring
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/6a4be621 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/6a4be621 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/6a4be621 Branch: refs/heads/LOG4J2-1278-gc-free-logger Commit: 6a4be621e3893d7a7fe823c39d693f8f5bbcb823 Parents: 22da4fb Author: rpopma <[email protected]> Authored: Fri Feb 26 03:51:13 2016 +0900 Committer: rpopma <[email protected]> Committed: Fri Feb 26 03:51:13 2016 +0900 ---------------------------------------------------------------------- .../ReusableParameterizedMessageFactory.java | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6a4be621/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessageFactory.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessageFactory.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessageFactory.java index 08aaa99..c07b930 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessageFactory.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessageFactory.java @@ -42,6 +42,15 @@ public final class ReusableParameterizedMessageFactory extends AbstractMessageFa super(); } + private static ReusableParameterizedMessage get() { + ReusableParameterizedMessage result = threadLocalMessage.get(); + if (result == null) { + result = new ReusableParameterizedMessage(); + threadLocalMessage.set(result); + } + return result; + } + /** * Creates {@link ReusableParameterizedMessage} instances. * @@ -53,12 +62,6 @@ public final class ReusableParameterizedMessageFactory extends AbstractMessageFa */ @Override public Message newMessage(final String message, final Object... params) { - ReusableParameterizedMessage result = threadLocalMessage.get(); - if (result == null) { - result = new ReusableParameterizedMessage(); - threadLocalMessage.set(result); - } - result.set(message, params); - return result; + return get().set(message, params); } }
