Repository: logging-log4j2 Updated Branches: refs/heads/master fc918475c -> e4eded22c
Use final. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e4eded22 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e4eded22 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e4eded22 Branch: refs/heads/master Commit: e4eded22cd3744a28bd5bcd9de41a035d13695f1 Parents: fc91847 Author: ggregory <[email protected]> Authored: Wed Mar 2 01:21:55 2016 -0800 Committer: ggregory <[email protected]> Committed: Wed Mar 2 01:21:55 2016 -0800 ---------------------------------------------------------------------- .../log4j/message/ReusableParameterizedMessage.java | 2 +- .../core/appender/rolling/DefaultRolloverStrategy.java | 4 ++-- .../logging/log4j/core/async/AsyncLoggerConfig.java | 2 +- .../log4j/core/config/AbstractConfiguration.java | 2 +- .../log4j/core/config/ConfiguratonFileWatcher.java | 4 ++-- .../log4j/core/pattern/DatePatternConverter.java | 4 ++-- .../apache/logging/log4j/core/util/WatchManager.java | 2 +- .../log4j/core/async/perftest/PerfTestDriver.java | 2 +- .../logging/log4j/core/util/WatchManagerTest.java | 6 +++--- .../logging/log4j/perf/jmh/CollectionsBenchmark.java | 12 ++++++------ .../logging/log4j/perf/jmh/LoggerConfigBenchmark.java | 8 ++++---- .../log4j/perf/jmh/ThreadLocalVsPoolBenchmark.java | 2 +- .../apache/logging/log4j/perf/nogc/AbstractLogger.java | 2 +- .../apache/logging/log4j/perf/nogc/DemoAppender.java | 2 +- .../org/apache/logging/log4j/perf/nogc/NoGcLayout.java | 6 +++--- .../org/apache/logging/log4j/perf/nogc/NoGcLogger.java | 2 +- .../org/apache/logging/log4j/perf/nogc/NoGcMessage.java | 6 +++--- .../log4j/configuration/CustomConfigurationTest.java | 2 +- 18 files changed, 35 insertions(+), 35 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java index a75c2d0..b4a1e5c 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java @@ -28,7 +28,7 @@ public class ReusableParameterizedMessage implements ReusableMessage { private static final long serialVersionUID = 7800075879295123856L; static class InternalState { - private StringBuilder buffer = new StringBuilder(2048); + private final StringBuilder buffer = new StringBuilder(2048); private String messagePattern; private int argCount; private transient Object[] varargs; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java index b030d17..e014bd7 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java @@ -192,9 +192,9 @@ public class DefaultRolloverStrategy implements RolloverStrategy { private final StrSubstitutor subst; private final int compressionLevel; - private List<Action> customActions; + private final List<Action> customActions; - private boolean stopCustomActionsOnError; + private final boolean stopCustomActionsOnError; /** * Constructs a new instance. http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java index 430d6c9..24d0086 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java @@ -68,7 +68,7 @@ import org.apache.logging.log4j.util.Strings; @Plugin(name = "asyncLogger", category = Node.CATEGORY, printObject = true) public class AsyncLoggerConfig extends LoggerConfig { - private AsyncLoggerConfigDelegate delegate; + private final AsyncLoggerConfigDelegate delegate; protected AsyncLoggerConfig(final String name, final List<AppenderRef> appenders, final Filter filter, http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java index 30a3652..e67e6ee 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java @@ -114,7 +114,7 @@ public abstract class AbstractConfiguration extends AbstractFilterable implement private final ConcurrentMap<String, Object> componentMap = new ConcurrentHashMap<>(); private final ConfigurationSource configurationSource; private ScriptManager scriptManager; - private ConfigurationScheduler configurationScheduler = new ConfigurationScheduler(); + private final ConfigurationScheduler configurationScheduler = new ConfigurationScheduler(); private final WatchManager watchManager = new WatchManager(configurationScheduler); private AsyncLoggerConfigDisruptor asyncLoggerConfigDisruptor; private NanoClock nanoClock = new DummyNanoClock(); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfiguratonFileWatcher.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfiguratonFileWatcher.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfiguratonFileWatcher.java index 1190b90..e268c54 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfiguratonFileWatcher.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfiguratonFileWatcher.java @@ -27,8 +27,8 @@ import java.util.List; */ public class ConfiguratonFileWatcher implements FileWatcher { - private Reconfigurable reconfigurable; - private List<ConfigurationListener> listeners; + private final Reconfigurable reconfigurable; + private final List<ConfigurationListener> listeners; public ConfiguratonFileWatcher(Reconfigurable reconfigurable, final List<ConfigurationListener> listeners) { this.reconfigurable = reconfigurable; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java index 9fdfcd8..b837338 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java @@ -82,7 +82,7 @@ public final class DatePatternConverter extends LogEventPatternConverter impleme private final FixedDateFormat fixedDateFormat; // below fields are only used in ThreadLocal caching mode - private char[] cachedBuffer = new char[64]; // max length of formatted date-time in any format < 64 + private final char[] cachedBuffer = new char[64]; // max length of formatted date-time in any format < 64 private int length = 0; FixedFormatter(final FixedDateFormat fixedDateFormat) { @@ -155,7 +155,7 @@ public final class DatePatternConverter extends LogEventPatternConverter impleme private static final String UNIX_MILLIS_FORMAT = "UNIX_MILLIS"; private final String[] options; - private ThreadLocal<Formatter> threadLocalFormatter = new ThreadLocal<>(); + private final ThreadLocal<Formatter> threadLocalFormatter = new ThreadLocal<>(); private final AtomicReference<CachedTime> cachedTime; private final Formatter formatter; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/main/java/org/apache/logging/log4j/core/util/WatchManager.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/util/WatchManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/util/WatchManager.java index db9fcfd..6da8d0f 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/util/WatchManager.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/util/WatchManager.java @@ -37,7 +37,7 @@ public class WatchManager extends AbstractLifeCycle { private final ConcurrentMap<File, FileMonitor> watchers = new ConcurrentHashMap<>(); private int intervalSeconds = 0; private ScheduledFuture<?> future; - private ConfigurationScheduler scheduler; + private final ConfigurationScheduler scheduler; public WatchManager(ConfigurationScheduler scheduler) { this.scheduler = scheduler; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java index d416dbf..de74115 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java @@ -197,7 +197,7 @@ public class PerfTestDriver { Log4j2(RunLog4j2.class), // Logback(RunLogback.class); - private Class<? extends IPerfTestRunner> implementationClass; + private final Class<? extends IPerfTestRunner> implementationClass; private Runner(Class<? extends IPerfTestRunner> cls) { this.implementationClass = cls; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchManagerTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchManagerTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchManagerTest.java index 4108f26..4953ac8 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchManagerTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchManagerTest.java @@ -39,9 +39,9 @@ import org.junit.Test; */ public class WatchManagerTest { - private String testFile = "target/testWatchFile"; - private String originalFile = "target/test-classes/log4j-test1.xml"; - private String newFile = "target/test-classes/log4j-test1.yaml"; + private final String testFile = "target/testWatchFile"; + private final String originalFile = "target/test-classes/log4j-test1.xml"; + private final String newFile = "target/test-classes/log4j-test1.yaml"; private static final boolean IS_WINDOWS = PropertiesUtil.getProperties().isOsWindows(); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/CollectionsBenchmark.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/CollectionsBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/CollectionsBenchmark.java index e6ef08c..37fa593 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/CollectionsBenchmark.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/CollectionsBenchmark.java @@ -39,12 +39,12 @@ import org.openjdk.jmh.infra.Blackhole; // @State(Scope.Benchmark) public class CollectionsBenchmark { - private ConcurrentHashMap<String, Long> map1 = new ConcurrentHashMap<String, Long>(); - private CopyOnWriteArraySet<Long> arraySet1 = new CopyOnWriteArraySet<Long>(); - private CopyOnWriteArrayList<Long> arrayList1 = new CopyOnWriteArrayList<Long>(); - private ConcurrentHashMap<String, Long> map3 = new ConcurrentHashMap<String, Long>(); - private CopyOnWriteArraySet<Long> arraySet3 = new CopyOnWriteArraySet<Long>(); - private CopyOnWriteArrayList<Long> arrayList3 = new CopyOnWriteArrayList<Long>(); + private final ConcurrentHashMap<String, Long> map1 = new ConcurrentHashMap<String, Long>(); + private final CopyOnWriteArraySet<Long> arraySet1 = new CopyOnWriteArraySet<Long>(); + private final CopyOnWriteArrayList<Long> arrayList1 = new CopyOnWriteArrayList<Long>(); + private final ConcurrentHashMap<String, Long> map3 = new ConcurrentHashMap<String, Long>(); + private final CopyOnWriteArraySet<Long> arraySet3 = new CopyOnWriteArraySet<Long>(); + private final CopyOnWriteArrayList<Long> arrayList3 = new CopyOnWriteArrayList<Long>(); @Setup public void setup() { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/LoggerConfigBenchmark.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/LoggerConfigBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/LoggerConfigBenchmark.java index 937b5bb..161d4d1 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/LoggerConfigBenchmark.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/LoggerConfigBenchmark.java @@ -51,17 +51,17 @@ import org.openjdk.jmh.infra.Blackhole; @State(Scope.Benchmark) public class LoggerConfigBenchmark { - private CopyOnWriteArraySet<AppenderControl> appenderSet = new CopyOnWriteArraySet<AppenderControl>(); + private final CopyOnWriteArraySet<AppenderControl> appenderSet = new CopyOnWriteArraySet<AppenderControl>(); private volatile Filter filter = null; - private boolean additive = true; - private boolean includeLocation = true; + private final boolean additive = true; + private final boolean includeLocation = true; private LoggerConfig parent; private final AtomicInteger counter = new AtomicInteger(); private final AtomicBoolean shutdown = new AtomicBoolean(false); private final Lock shutdownLock = new ReentrantLock(); private final Condition noLogEvents = shutdownLock.newCondition(); // should only be used when shutdown == true private final LogEvent LOGEVENT = createLogEventWithoutException(); - private SimpleListAppender listAppender = new SimpleListAppender(); + private final SimpleListAppender listAppender = new SimpleListAppender(); private static class SimpleListAppender extends AbstractAppender { private static final long serialVersionUID = 1L; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadLocalVsPoolBenchmark.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadLocalVsPoolBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadLocalVsPoolBenchmark.java index a05f121..113e56a 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadLocalVsPoolBenchmark.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadLocalVsPoolBenchmark.java @@ -72,7 +72,7 @@ public class ThreadLocalVsPoolBenchmark { */ private final static PatternFormatter[] formatters = createFormatters(); - private StringBuilderPool pool = new StringBuilderPool(DEFAULT_STRING_BUILDER_SIZE); + private final StringBuilderPool pool = new StringBuilderPool(DEFAULT_STRING_BUILDER_SIZE); private static ThreadLocal<StringBuilder> threadLocal = new ThreadLocal<>(); /** http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/AbstractLogger.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/AbstractLogger.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/AbstractLogger.java index 471e30c..08e757e 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/AbstractLogger.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/AbstractLogger.java @@ -24,7 +24,7 @@ import org.apache.logging.log4j.message.Message; * Logic common among ClassicLogger and NoGcLogger. */ public abstract class AbstractLogger { - private MutableLogEvent reusedLogEvent = new MutableLogEvent(); + private final MutableLogEvent reusedLogEvent = new MutableLogEvent(); protected DemoAppender appender = new DemoAppender(createLayout()); protected abstract Layout<?> createLayout(); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/DemoAppender.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/DemoAppender.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/DemoAppender.java index fd05ac3..2f3851d 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/DemoAppender.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/DemoAppender.java @@ -27,7 +27,7 @@ import org.apache.logging.log4j.core.layout.ByteBufferDestination; * Demo Appender that does not do any I/O. */ public class DemoAppender extends AbstractAppender implements ByteBufferDestination { - private ByteBuffer byteBuffer = ByteBuffer.wrap(new byte[4096]); + private final ByteBuffer byteBuffer = ByteBuffer.wrap(new byte[4096]); public long checksum; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLayout.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLayout.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLayout.java index f47a60e..345a231 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLayout.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLayout.java @@ -37,9 +37,9 @@ import java.util.Map; * </p> */ public class NoGcLayout implements Layout<Serializable>, Encoder<LogEvent> { - private StringBuilder cachedStringBuilder = new StringBuilder(2048); - private PatternSerializer2 serializer = new PatternSerializer2(); - private TextEncoderHelper cachedHelper; + private final StringBuilder cachedStringBuilder = new StringBuilder(2048); + private final PatternSerializer2 serializer = new PatternSerializer2(); + private final TextEncoderHelper cachedHelper; public NoGcLayout(Charset charset) { cachedHelper = new TextEncoderHelper(charset); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLogger.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLogger.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLogger.java index f4d5faf..687b718 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLogger.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcLogger.java @@ -24,7 +24,7 @@ import java.nio.charset.StandardCharsets; * Logger with unrolled varargs, cached Message and NoGcLayout. */ public class NoGcLogger extends AbstractLogger { - private NoGcMessage reusedMessage = new NoGcMessage(); + private final NoGcMessage reusedMessage = new NoGcMessage(); @Override protected Layout<?> createLayout() { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcMessage.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcMessage.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcMessage.java index 004111e..fdb84d9 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcMessage.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/NoGcMessage.java @@ -25,16 +25,16 @@ import java.util.Arrays; */ public class NoGcMessage implements Message { class InternalState { - private Object[] params = new Object[10]; + private final Object[] params = new Object[10]; private int paramCount; - private StringBuilder buffer = new StringBuilder(2048); + private final StringBuilder buffer = new StringBuilder(2048); public Object[] getParamsCopy() { return Arrays.copyOf(params, paramCount); } } - private ThreadLocal<InternalState> state = new ThreadLocal<>(); + private final ThreadLocal<InternalState> state = new ThreadLocal<>(); public NoGcMessage() { } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e4eded22/log4j-samples/configuration/src/test/java/org/apache/logging/log4j/configuration/CustomConfigurationTest.java ---------------------------------------------------------------------- diff --git a/log4j-samples/configuration/src/test/java/org/apache/logging/log4j/configuration/CustomConfigurationTest.java b/log4j-samples/configuration/src/test/java/org/apache/logging/log4j/configuration/CustomConfigurationTest.java index 22e37ef..054a0f3 100644 --- a/log4j-samples/configuration/src/test/java/org/apache/logging/log4j/configuration/CustomConfigurationTest.java +++ b/log4j-samples/configuration/src/test/java/org/apache/logging/log4j/configuration/CustomConfigurationTest.java @@ -24,7 +24,7 @@ import org.junit.Test; * */ public class CustomConfigurationTest { - private Logger logger = LogManager.getLogger(CustomConfiguration.class); + private final Logger logger = LogManager.getLogger(CustomConfiguration.class); @Test public void testLogging() {
