LOG4J2-1343 simplified RandomAccessFileAppender to reuse the garbage-free Layout mechanism defined in the superclass
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e0fa54a6 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e0fa54a6 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e0fa54a6 Branch: refs/heads/LOG4J2-1356 Commit: e0fa54a67ca5991305528f77fdb19b99357f7403 Parents: 389b391 Author: rpopma <[email protected]> Authored: Thu Apr 7 03:01:45 2016 +0900 Committer: rpopma <[email protected]> Committed: Thu Apr 7 03:01:45 2016 +0900 ---------------------------------------------------------------------- .../log4j/core/appender/RandomAccessFileAppender.java | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e0fa54a6/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java index 8bcf8e2..043bccf 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RandomAccessFileAppender.java @@ -85,17 +85,8 @@ public final class RandomAccessFileAppender extends AbstractOutputStreamAppender // of immediateFlush=true. getManager().setEndOfBatch(event.isEndOfBatch()); - // LOG4J2-1292 utilize gc-free Layout.encode() method - // super.append(event); - try { - getLayout().encode(event, getManager()); - if (getImmediateFlush() || event.isEndOfBatch()) { - getManager().flush(); - } - } catch (final AppenderLoggingException ex) { - error("Unable to write to stream " + getManager().getName() + " for appender " + getName()); - throw ex; - } + // LOG4J2-1292 utilize gc-free Layout.encode() method: taken care of in superclass + super.append(event); } /**
