Add final modifier to private fields. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/4a2ad0c2 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/4a2ad0c2 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/4a2ad0c2
Branch: refs/heads/LOG4J2-1365 Commit: 4a2ad0c265a83cc22dde99060f23fcfd6828ce52 Parents: 1494ce2 Author: ggregory <[email protected]> Authored: Sun Apr 17 16:31:51 2016 -0700 Committer: ggregory <[email protected]> Committed: Sun Apr 17 16:31:51 2016 -0700 ---------------------------------------------------------------------- .../apache/logging/log4j/message/ReusableParameterizedMessage.java | 2 +- .../org/apache/logging/log4j/core/appender/SocketAppenderTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/4a2ad0c2/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java index 0c099cf..87cdc1d 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java @@ -36,7 +36,7 @@ public class ReusableParameterizedMessage implements ReusableMessage { private String messagePattern; private int argCount; private int usedCount; - private int[] indices = new int[256]; + private final int[] indices = new int[256]; private transient Object[] varargs; private transient Object[] params = new Object[10]; private transient Throwable throwable; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/4a2ad0c2/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java index 50586f7..9564dd9 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java @@ -213,7 +213,7 @@ public class SocketAppenderTest { private final DatagramSocket sock; private boolean shutdown = false; private Thread thread; - private CountDownLatch latch = new CountDownLatch(1); + private final CountDownLatch latch = new CountDownLatch(1); public UDPSocketServer() throws IOException { this.sock = new DatagramSocket(PORT);
