Add final modifier to private fields. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/fe22ab84 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/fe22ab84 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/fe22ab84
Branch: refs/heads/master Commit: fe22ab84e439673a4cd653d06ea953c9b1f25f3f Parents: 2693d25 Author: ggregory <ggreg...@apache.org> Authored: Fri Jun 3 10:04:33 2016 -0700 Committer: ggregory <ggreg...@apache.org> Committed: Fri Jun 3 10:04:33 2016 -0700 ---------------------------------------------------------------------- .../apache/logging/log4j/core/appender/CountingNoOpAppender.java | 2 +- .../log4j/core/config/composite/CompositeConfiguration.java | 2 +- .../apache/logging/log4j/core/async/perftest/ResponseTimeTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/fe22ab84/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/CountingNoOpAppender.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/CountingNoOpAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/CountingNoOpAppender.java index a8e48dc..8164aea 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/CountingNoOpAppender.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/CountingNoOpAppender.java @@ -31,7 +31,7 @@ import org.apache.logging.log4j.core.config.plugins.PluginFactory; @Plugin(name = "CountingNoOp", category = "Core", elementType = "appender", printObject = true) public class CountingNoOpAppender extends AbstractAppender { - private AtomicLong total = new AtomicLong(); + private final AtomicLong total = new AtomicLong(); public CountingNoOpAppender(String name, Layout<?> layout) { super(name, null, layout); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/fe22ab84/log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.java index 68fbc3b..60d98f0 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/composite/CompositeConfiguration.java @@ -52,7 +52,7 @@ public class CompositeConfiguration extends AbstractConfiguration implements Rec private static final String[] VERBOSE_CLASSES = new String[] {ResolverUtil.class.getName()}; - private List<? extends AbstractConfiguration> configurations; + private final List<? extends AbstractConfiguration> configurations; private MergeStrategy mergeStrategy; http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/fe22ab84/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/ResponseTimeTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/ResponseTimeTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/ResponseTimeTest.java index c584f7e..1ad25db 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/ResponseTimeTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/ResponseTimeTest.java @@ -281,7 +281,7 @@ public class ResponseTimeTest { private long unitsCompletedAtCatchUpStart; private double catchUpThroughputInUnitsPerNsec; private double catchUpRateMultiple; - private IdleStrategy idleStrategy; + private final IdleStrategy idleStrategy; public Pacer(double unitsPerSec, IdleStrategy idleStrategy) { this(unitsPerSec, 3.0, idleStrategy); // Default to catching up at 3x the set throughput
