Repository: logging-log4j2
Updated Branches:
  refs/heads/master 2445ec166 -> d625f882a


Improve test error message


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d625f882
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d625f882
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d625f882

Branch: refs/heads/master
Commit: d625f882a74f3a581212da38b1a77c970d8df8f7
Parents: 2445ec1
Author: rpopma <[email protected]>
Authored: Sun Jun 12 14:10:21 2016 +0900
Committer: rpopma <[email protected]>
Committed: Sun Jun 12 14:10:21 2016 +0900

----------------------------------------------------------------------
 .../core/appender/rolling/RollingAppenderOnStartupTest.java | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d625f882/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java
index 3d1e704..215f3a7 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java
@@ -35,10 +35,7 @@ import static 
org.apache.logging.log4j.hamcrest.Descriptors.that;
 import static org.apache.logging.log4j.hamcrest.FileMatchers.hasName;
 import static org.hamcrest.Matchers.endsWith;
 import static org.hamcrest.Matchers.hasItemInArray;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import static org.junit.Assert.*;
 
 /**
  *
@@ -80,9 +77,9 @@ public class RollingAppenderOnStartupTest {
         try (DirectoryStream<Path> directoryStream = 
Files.newDirectoryStream(Paths.get("target/onStartup"))) {
             for (Path path : directoryStream) {
                 if (size == 0) {
-                    size = Files.size(path);
+                    size = Files.size(path); // remember size of first 
non-empty file
                 } else {
-                    assertTrue(size == Files.size(path));
+                    assertEquals("Size of " + path, size, Files.size(path));
                 }
                 Files.delete(path);
             }

Reply via email to