Repository: logging-log4j2 Updated Branches: refs/heads/master 922cdf040 -> 48a6dd984
Move the offset closer to its use sites (inside the if block). Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/48a6dd98 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/48a6dd98 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/48a6dd98 Branch: refs/heads/master Commit: 48a6dd984b33048af6f078d7923ca2ac50c02559 Parents: 922cdf0 Author: Gary Gregory <ggreg...@apache.org> Authored: Sun Jun 26 13:47:16 2016 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Sun Jun 26 13:47:16 2016 -0700 ---------------------------------------------------------------------- .../apache/logging/log4j/core/pattern/MessagePatternConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/48a6dd98/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java index 1315663..959b308 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java @@ -61,11 +61,11 @@ public final class MessagePatternConverter extends LogEventPatternConverter { public void format(final LogEvent event, final StringBuilder toAppendTo) { final Message msg = event.getMessage(); if (msg instanceof StringBuilderFormattable) { - final int offset = toAppendTo.length(); ((StringBuilderFormattable) msg).formatTo(toAppendTo); // TODO can we optimize this? if (config != null) { + final int offset = toAppendTo.length(); for (int i = offset; i < toAppendTo.length() - 1; i++) { if (toAppendTo.charAt(i) == '$' && toAppendTo.charAt(i + 1) == '{') { final String value = toAppendTo.substring(offset, toAppendTo.length());
