Update test with a better logging message. Add a comment. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/685881a2 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/685881a2 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/685881a2
Branch: refs/heads/LOG4J2-1010&LOG4J2-1447-injectable-contextdata&better-datastructure Commit: 685881a249f261b18bfd11838796054b6da6fc3c Parents: 2404f7c Author: Gary Gregory <ggreg...@apache.org> Authored: Wed Aug 10 13:49:05 2016 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Wed Aug 10 13:49:05 2016 -0700 ---------------------------------------------------------------------- .../log4j/core/appender/rolling/RollingAppenderCronTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/685881a2/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderCronTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderCronTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderCronTest.java index a6498bf..6de7d7d 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderCronTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderCronTest.java @@ -56,6 +56,7 @@ public class RollingAppenderCronTest { @Test public void testAppender() throws Exception { + // TODO Is there a better way to test than putting the thread to sleep all over the place? final Logger logger = loggerContextRule.getLogger(); File file = new File(FILE); assertTrue("Log file does not exist", file.exists()); @@ -73,7 +74,7 @@ public class RollingAppenderCronTest { succeeded = true; break; } - logger.debug("Adding additional event " + i); + logger.debug("Sleeping #" + i); Thread.sleep(100); // Allow time for rollover to complete } if (!succeeded) {
