Better failure message. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/8c80cb9b Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/8c80cb9b Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/8c80cb9b
Branch: refs/heads/LOG4J2-1349-gcfree-threadcontext Commit: 8c80cb9b74e730283def89c25329ce3eab410472 Parents: 099775b Author: Gary Gregory <ggreg...@apache.org> Authored: Thu Sep 8 14:59:02 2016 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Thu Sep 8 14:59:02 2016 -0700 ---------------------------------------------------------------------- .../log4j/core/appender/AsyncAppenderTest.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/8c80cb9b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java index 26488a5..8c57efd 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/AsyncAppenderTest.java @@ -78,9 +78,12 @@ public class AsyncAppenderTest { final Logger logger = LogManager.getLogger(AsyncAppender.class); logger.error("This is a test"); logger.warn("Hello world!"); - final List<String> list = listAppender.getMessages(TIMEOUT_MILLIS, TimeUnit.MILLISECONDS); + final int timeoutMillis = TIMEOUT_MILLIS; + final TimeUnit timeUnit = TimeUnit.MILLISECONDS; + final List<String> list = listAppender.getMessages(timeoutMillis, timeUnit); assertNotNull("No events generated", list); - assertTrue("Incorrect number of events. Expected 2, got " + list.size(), list.size() == 2); + assertTrue("Incorrect number of events after " + timeoutMillis + " " + timeUnit + ". Expected 2, got " + + list.size(), list.size() == 2); String msg = list.get(0); String expected = AsyncAppenderTest.class.getName() + " rewriteTest This is a test"; assertTrue("Expected " + expected + ", Actual " + msg, expected.equals(msg)); @@ -95,9 +98,12 @@ public class AsyncAppenderTest { final Exception parent = new IllegalStateException("Test"); final Throwable child = new LoggingException("This is a test", parent); logger.error("This is a test", child); - final List<String> list = listAppender.getMessages(TIMEOUT_MILLIS, TimeUnit.MILLISECONDS); + final int timeoutMillis = TIMEOUT_MILLIS; + final TimeUnit timeUnit = TimeUnit.MILLISECONDS; + final List<String> list = listAppender.getMessages(timeoutMillis, timeUnit); assertNotNull("No events generated", list); - assertTrue("Incorrect number of events. Expected 1, got " + list.size(), list.size() == 1); + assertTrue("Incorrect number of events after " + timeoutMillis + " " + timeUnit + ". Expected 1, got " + + list.size(), list.size() == 1); final String msg = list.get(0); assertTrue("No parent exception", msg.contains("java.lang.IllegalStateException")); }
