Repository: logging-log4j2
Updated Branches:
  refs/heads/master e889d2b24 -> d73d2a189


Add final modifier to method parameters.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d73d2a18
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d73d2a18
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d73d2a18

Branch: refs/heads/master
Commit: d73d2a1895536217ba4830d212a4926027dd4ea4
Parents: e889d2b
Author: Gary Gregory <ggreg...@apache.org>
Authored: Mon Sep 19 22:23:28 2016 -0700
Committer: Gary Gregory <ggreg...@apache.org>
Committed: Mon Sep 19 22:23:28 2016 -0700

----------------------------------------------------------------------
 .../org/apache/logging/log4j/util/ArrayContextData.java | 12 ++++++------
 .../apache/logging/log4j/core/AbstractLifeCycle.java    |  2 +-
 .../apache/logging/log4j/core/appender/AppenderSet.java |  2 +-
 .../apache/logging/log4j/core/script/ScriptManager.java |  4 ++--
 .../AsyncLoggerAllThreadContextImplementationsTest.java |  2 +-
 ...LoggerConfigAllThreadContextImplementationsTest.java |  2 +-
 .../logging/log4j/test/appender/ListAppender.java       |  2 +-
 .../perf/jmh/ArrayContextDataVsHashMapBenchmark.java    |  6 +++---
 .../logging/log4j/perf/nogc/OpenHashMapContextData.java |  2 +-
 9 files changed, 17 insertions(+), 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-api/src/main/java/org/apache/logging/log4j/util/ArrayContextData.java
----------------------------------------------------------------------
diff --git 
a/log4j-api/src/main/java/org/apache/logging/log4j/util/ArrayContextData.java 
b/log4j-api/src/main/java/org/apache/logging/log4j/util/ArrayContextData.java
index 98508a3..cd88e47 100644
--- 
a/log4j-api/src/main/java/org/apache/logging/log4j/util/ArrayContextData.java
+++ 
b/log4j-api/src/main/java/org/apache/logging/log4j/util/ArrayContextData.java
@@ -265,7 +265,7 @@ public class ArrayContextData implements MutableContextData 
{
     /**
      * Inflates the table.
      */
-    private void inflateTable(int toSize) {
+    private void inflateTable(final int toSize) {
         threshold = toSize;
         keys = new String[toSize];
         values = new Object[toSize];
@@ -312,7 +312,7 @@ public class ArrayContextData implements MutableContextData 
{
 
     @SuppressWarnings("unchecked")
     @Override
-    public <V> void forEach(BiConsumer<String, ? super V> action) {
+    public <V> void forEach(final BiConsumer<String, ? super V> action) {
         iterating = true;
         try {
             for (int i = 0; i < size; i++) {
@@ -325,7 +325,7 @@ public class ArrayContextData implements MutableContextData 
{
 
     @SuppressWarnings("unchecked")
     @Override
-    public <V, T> void forEach(TriConsumer<String, ? super V, T> action, T 
state) {
+    public <V, T> void forEach(final TriConsumer<String, ? super V, T> action, 
final T state) {
         iterating = true;
         try {
             for (int i = 0; i < size; i++) {
@@ -368,7 +368,7 @@ public class ArrayContextData implements MutableContextData 
{
         return result;
     }
 
-    private static int hashCode(Object[] values, int length) {
+    private static int hashCode(final Object[] values, final int length) {
         int result = 1;
         for (int i = 0; i < length; i++) {
             result = HASHVAL * result + (values[i] == null ? 0 : 
values[i].hashCode());
@@ -402,7 +402,7 @@ public class ArrayContextData implements MutableContextData 
{
      *             for each key-value mapping.  The key-value mappings are
      *             emitted in no particular order.
      */
-    private void writeObject(java.io.ObjectOutputStream s) throws IOException {
+    private void writeObject(final java.io.ObjectOutputStream s) throws 
IOException {
         // Write out the threshold, and any hidden stuff
         s.defaultWriteObject();
 
@@ -443,7 +443,7 @@ public class ArrayContextData implements MutableContextData 
{
      * Reconstitute the {@code ArrayContextData} instance from a stream (i.e.,
      * deserialize it).
      */
-    private void readObject(java.io.ObjectInputStream s)  throws IOException, 
ClassNotFoundException {
+    private void readObject(final java.io.ObjectInputStream s)  throws 
IOException, ClassNotFoundException {
         // Read in the threshold (ignored), and any hidden stuff
         s.defaultReadObject();
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-core/src/main/java/org/apache/logging/log4j/core/AbstractLifeCycle.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/AbstractLifeCycle.java 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/AbstractLifeCycle.java
index ffc50a9..dc720fd 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/AbstractLifeCycle.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/AbstractLifeCycle.java
@@ -127,7 +127,7 @@ public class AbstractLifeCycle implements LifeCycle2 {
         stop(DEFAULT_STOP_TIMEOUT, DEFAULT_STOP_TIMEUNIT);
     }
 
-    protected boolean stop(Future<?> future) {
+    protected boolean stop(final Future<?> future) {
         boolean stopped = true;
         if (future != null) {
             if (future.isCancelled() || future.isDone()) {

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AppenderSet.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AppenderSet.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AppenderSet.java
index 6adf89f..2f53224 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AppenderSet.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AppenderSet.java
@@ -108,7 +108,7 @@ public class AppenderSet {
         this.nodeMap = appenders;
     }
 
-    public Appender createAppender(final String appenderName, String 
actualName) {
+    public Appender createAppender(final String appenderName, final String 
actualName) {
         final Node node = nodeMap.get(appenderName);
         if (node == null) {
             LOGGER.error("No node named {} in {}", appenderName, this);

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-core/src/main/java/org/apache/logging/log4j/core/script/ScriptManager.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/script/ScriptManager.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/script/ScriptManager.java
index 3e274c9..d4f5717 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/script/ScriptManager.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/script/ScriptManager.java
@@ -135,7 +135,7 @@ public class ScriptManager implements FileWatcher, 
Serializable {
         }
     }
 
-    public Bindings createBindings(AbstractScript script) {
+    public Bindings createBindings(final AbstractScript script) {
         return getScriptRunner(script).createBindings();
     }
 
@@ -274,7 +274,7 @@ public class ScriptManager implements FileWatcher, 
Serializable {
         }
     }
 
-    private ScriptRunner getScriptRunner(AbstractScript script) {
+    private ScriptRunner getScriptRunner(final AbstractScript script) {
         return scriptRunners.get(script.getName());
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
index 35edf29..6e42149 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
@@ -120,7 +120,7 @@ public class AsyncLoggerAllThreadContextImplementationsTest 
{
         });
     }
 
-    public AsyncLoggerAllThreadContextImplementationsTest(ContextImpl 
contextImpl, Mode asyncMode) {
+    public AsyncLoggerAllThreadContextImplementationsTest(final ContextImpl 
contextImpl, final Mode asyncMode) {
         this.contextImpl = contextImpl;
         this.asyncMode = asyncMode;
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
index 6ec9640..a79e8a3 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
@@ -98,7 +98,7 @@ public class 
AsyncLoggerConfigAllThreadContextImplementationsTest {
         });
     }
 
-    public AsyncLoggerConfigAllThreadContextImplementationsTest(ContextImpl 
contextImpl) {
+    public AsyncLoggerConfigAllThreadContextImplementationsTest(final 
ContextImpl contextImpl) {
         this.contextImpl = contextImpl;
         contextImpl.init();
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-core/src/test/java/org/apache/logging/log4j/test/appender/ListAppender.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/test/appender/ListAppender.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/test/appender/ListAppender.java
index 0d24420..64ed6af 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/test/appender/ListAppender.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/test/appender/ListAppender.java
@@ -180,7 +180,7 @@ public class ListAppender extends AbstractAppender {
      * Polls the messages list for it to grow to a given minimum size at most 
timeout timeUnits and return a copy of
      * what we have so far.
      */
-    public List<String> getMessages(int minSize, long timeout, TimeUnit 
timeUnit) throws InterruptedException {
+    public List<String> getMessages(final int minSize, final long timeout, 
final TimeUnit timeUnit) throws InterruptedException {
         final long endMillis = System.currentTimeMillis() + 
timeUnit.toMillis(timeout);
         while (messages.size() < minSize && System.currentTimeMillis() < 
endMillis) {
             Thread.sleep(100);

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ArrayContextDataVsHashMapBenchmark.java
----------------------------------------------------------------------
diff --git 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ArrayContextDataVsHashMapBenchmark.java
 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ArrayContextDataVsHashMapBenchmark.java
index 23cca6b..b32b44e 100644
--- 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ArrayContextDataVsHashMapBenchmark.java
+++ 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/ArrayContextDataVsHashMapBenchmark.java
@@ -147,7 +147,7 @@ public class ArrayContextDataVsHashMapBenchmark {
 
     static TriConsumer<String, Object, int[]> COUNTER = new 
TriConsumer<String, Object, int[]>() {
         @Override
-        public void accept(String s, Object o, int[] result) {
+        public void accept(final String s, final Object o, final int[] result) 
{
             result[0] += s.hashCode() + o.hashCode();
         }
     };
@@ -174,7 +174,7 @@ public class ArrayContextDataVsHashMapBenchmark {
 
         populatedContextData.forEach(new BiConsumer<String, Object>() {
             @Override
-            public void accept(String s, Object o) {
+            public void accept(final String s, final Object o) {
                 result[0] += s.hashCode() + o.hashCode();
             }
         });
@@ -187,7 +187,7 @@ public class ArrayContextDataVsHashMapBenchmark {
 
         populatedHashContextData.forEach(new BiConsumer<String, Object>() {
             @Override
-            public void accept(String s, Object o) {
+            public void accept(final String s, final Object o) {
                 result[0] += s.hashCode() + o.hashCode();
             }
         });

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d73d2a18/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
----------------------------------------------------------------------
diff --git 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
index 8a3bf17..510ad96 100644
--- 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
+++ 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
@@ -495,7 +495,7 @@ public class OpenHashMapContextData<K, V> implements 
MutableContextData, ThreadC
     }
 
     /** {@inheritDoc} */
-    public void putAll(Map<? extends K, ? extends V> map) {
+    public void putAll(final Map<? extends K, ? extends V> map) {
         if (loadFactor <= .5) {
             // The resulting map will be sized for m.size() elements
             ensureCapacity(map.size());

Reply via email to