Stop the context to make sure all files are compressed and closed. Trying to remedy failures in CI builds.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/166d3fab Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/166d3fab Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/166d3fab Branch: refs/heads/LOG4J2-1390 Commit: 166d3fab4376125aa30e7b0c63d64eef99a02eb9 Parents: 560120b Author: Gary Gregory <ggreg...@apache.org> Authored: Wed Sep 28 22:00:57 2016 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Wed Sep 28 22:00:57 2016 -0700 ---------------------------------------------------------------------- .../log4j/core/appender/rolling/RollingAppenderSizeTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/166d3fab/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeTest.java index addc42d..cb3bc98 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeTest.java @@ -140,7 +140,9 @@ public class RollingAppenderSizeTest { return; // Apache Commons Compress cannot deflate zip? TODO test decompressing these formats } // Stop the context to make sure all files are compressed and closed. Trying to remedy failures in CI builds. - loggerContextRule.getLoggerContext().stop(30, TimeUnit.SECONDS); + if (loggerContextRule.getLoggerContext().stop(30, TimeUnit.SECONDS)) { + System.err.println("Could not stop cleanly " + loggerContextRule + " for " + this); + } for (final File file : files) { if (file.getName().endsWith(fileExtension)) { CompressorInputStream in = null;