Repository: logging-log4j2 Updated Branches: refs/heads/master ef2ab0df1 -> 1eebba86b
Add final modifier to private fields Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/ba484177 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/ba484177 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/ba484177 Branch: refs/heads/master Commit: ba4841778c9e83038b216a430c544c2afcfe2c5f Parents: ef2ab0d Author: Gary Gregory <[email protected]> Authored: Sat Nov 12 01:10:35 2016 -0800 Committer: Gary Gregory <[email protected]> Committed: Sat Nov 12 01:10:35 2016 -0800 ---------------------------------------------------------------------- .../org/apache/logging/log4j/spi/LoggerAdapterTest.java | 10 +++++----- .../apache/logging/log4j/FilterPerformanceComparison.java | 2 +- .../logging/log4j/web/appender/ServletAppender.java | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ba484177/log4j-api/src/test/java/org/apache/logging/log4j/spi/LoggerAdapterTest.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/test/java/org/apache/logging/log4j/spi/LoggerAdapterTest.java b/log4j-api/src/test/java/org/apache/logging/log4j/spi/LoggerAdapterTest.java index b04fe6f..b00fea7 100644 --- a/log4j-api/src/test/java/org/apache/logging/log4j/spi/LoggerAdapterTest.java +++ b/log4j-api/src/test/java/org/apache/logging/log4j/spi/LoggerAdapterTest.java @@ -32,13 +32,13 @@ import static org.junit.Assert.assertSame; public class LoggerAdapterTest { private class RunnableThreadTest implements Runnable { - private AbstractLoggerAdapter<Logger> adapter; - private LoggerContext context; - private CountDownLatch doneSignal; - private int index; + private final AbstractLoggerAdapter<Logger> adapter; + private final LoggerContext context; + private final CountDownLatch doneSignal; + private final int index; private Map<String, Logger> resultMap; - private CountDownLatch startSignal; + private final CountDownLatch startSignal; public RunnableThreadTest(int index, TestLoggerAdapter adapter, LoggerContext context, CountDownLatch startSignal, CountDownLatch doneSignal) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ba484177/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java b/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java index df305db..68cfad1 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/FilterPerformanceComparison.java @@ -191,7 +191,7 @@ public class FilterPerformanceComparison { private final int count; private final long[] results; private final int index; - private Map<String, String> contextData; + private final Map<String, String> contextData; public Worker(final Target target, final int count, final long[] results, final int index, final Map<String, String> contextData) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ba484177/log4j-web/src/main/java/org/apache/logging/log4j/web/appender/ServletAppender.java ---------------------------------------------------------------------- diff --git a/log4j-web/src/main/java/org/apache/logging/log4j/web/appender/ServletAppender.java b/log4j-web/src/main/java/org/apache/logging/log4j/web/appender/ServletAppender.java index 8721de1..a0c9478 100644 --- a/log4j-web/src/main/java/org/apache/logging/log4j/web/appender/ServletAppender.java +++ b/log4j-web/src/main/java/org/apache/logging/log4j/web/appender/ServletAppender.java @@ -88,7 +88,7 @@ public class ServletAppender extends AbstractAppender { } private final ServletContext servletContext; - private boolean logThrowables; + private final boolean logThrowables; private ServletAppender(final String name, final Layout<? extends Serializable> layout, final Filter filter, final ServletContext servletContext, final boolean ignoreExceptions, final boolean logThrowables) {
