Add final modifier to method parameters. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/614b9a7f Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/614b9a7f Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/614b9a7f
Branch: refs/heads/master Commit: 614b9a7f898fef96ddaf8193922c244d13199757 Parents: bcf5ad0 Author: Gary Gregory <[email protected]> Authored: Mon Nov 14 15:30:29 2016 -0800 Committer: Gary Gregory <[email protected]> Committed: Mon Nov 14 15:30:29 2016 -0800 ---------------------------------------------------------------------- .../core/appender/MemoryMappedFileAppender.java | 12 +++---- .../log4j/core/appender/SyslogAppender.java | 36 ++++++++++---------- .../log4j/core/net/SslSocketManager.java | 4 +-- .../log4j/core/net/TcpSocketManager.java | 4 +-- .../log4j/core/pattern/PatternParser.java | 2 +- .../log4j/core/appender/SocketAppenderTest.java | 2 +- 6 files changed, 30 insertions(+), 30 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/614b9a7f/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java index c821129..3a24d9e 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/MemoryMappedFileAppender.java @@ -95,32 +95,32 @@ public final class MemoryMappedFileAppender extends AbstractOutputStreamAppender advertise ? configuration.getAdvertiser() : null); } - public B setFileName(String fileName) { + public B setFileName(final String fileName) { this.fileName = fileName; return asBuilder(); } - public B setAppend(boolean append) { + public B setAppend(final boolean append) { this.append = append; return asBuilder(); } - public B setRegionLength(int regionLength) { + public B setRegionLength(final int regionLength) { this.regionLength = regionLength; return asBuilder(); } - public B setAdvertise(boolean advertise) { + public B setAdvertise(final boolean advertise) { this.advertise = advertise; return asBuilder(); } - public B setAdvertiseURI(String advertiseURI) { + public B setAdvertiseURI(final String advertiseURI) { this.advertiseURI = advertiseURI; return asBuilder(); } - public B setConfiguration(Configuration configuration) { + public B setConfiguration(final Configuration configuration) { this.configuration = configuration; return asBuilder(); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/614b9a7f/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java index 2fc73d8..5f06c44 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SyslogAppender.java @@ -199,92 +199,92 @@ public class SyslogAppender extends SocketAppender { return loggerFields; } - public Builder setFacility(Facility facility) { + public Builder setFacility(final Facility facility) { this.facility = facility; return this; } - public Builder setId(String id) { + public Builder setId(final String id) { this.id = id; return this; } - public Builder setEnterpriseNumber(int enterpriseNumber) { + public Builder setEnterpriseNumber(final int enterpriseNumber) { this.enterpriseNumber = enterpriseNumber; return this; } - public Builder setIncludeMdc(boolean includeMdc) { + public Builder setIncludeMdc(final boolean includeMdc) { this.includeMdc = includeMdc; return this; } - public Builder setMdcId(String mdcId) { + public Builder setMdcId(final String mdcId) { this.mdcId = mdcId; return this; } - public Builder setMdcPrefix(String mdcPrefix) { + public Builder setMdcPrefix(final String mdcPrefix) { this.mdcPrefix = mdcPrefix; return this; } - public Builder setEventPrefix(String eventPrefix) { + public Builder setEventPrefix(final String eventPrefix) { this.eventPrefix = eventPrefix; return this; } - public Builder setNewLine(boolean newLine) { + public Builder setNewLine(final boolean newLine) { this.newLine = newLine; return this; } - public Builder setEscapeNL(String escapeNL) { + public Builder setEscapeNL(final String escapeNL) { this.escapeNL = escapeNL; return this; } - public Builder setAppName(String appName) { + public Builder setAppName(final String appName) { this.appName = appName; return this; } - public Builder setMsgId(String msgId) { + public Builder setMsgId(final String msgId) { this.msgId = msgId; return this; } - public Builder setExcludes(String excludes) { + public Builder setExcludes(final String excludes) { this.excludes = excludes; return this; } - public Builder setIncludes(String includes) { + public Builder setIncludes(final String includes) { this.includes = includes; return this; } - public Builder setRequired(String required) { + public Builder setRequired(final String required) { this.required = required; return this; } - public Builder setFormat(String format) { + public Builder setFormat(final String format) { this.format = format; return this; } - public Builder setCharsetName(Charset charset) { + public Builder setCharsetName(final Charset charset) { this.charsetName = charset; return this; } - public Builder setExceptionPattern(String exceptionPattern) { + public Builder setExceptionPattern(final String exceptionPattern) { this.exceptionPattern = exceptionPattern; return this; } - public Builder setLoggerFields(LoggerFields[] loggerFields) { + public Builder setLoggerFields(final LoggerFields[] loggerFields) { this.loggerFields = loggerFields; return this; } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/614b9a7f/log4j-core/src/main/java/org/apache/logging/log4j/core/net/SslSocketManager.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/SslSocketManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/SslSocketManager.java index c9d5c6e..57a4b43 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/SslSocketManager.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/SslSocketManager.java @@ -119,8 +119,8 @@ public class SslSocketManager extends TcpSocketManager { * @deprecated Use {@link SslSocketManager#getSocketManager(SslConfiguration, String, int, int, int, boolean, Layout, int, SocketOptions)}. */ @Deprecated - public static SslSocketManager getSocketManager(final SslConfiguration sslConfig, final String host, int port, - final int connectTimeoutMillis, int reconnectDelayMillis, final boolean immediateFail, + public static SslSocketManager getSocketManager(final SslConfiguration sslConfig, final String host, final int port, + final int connectTimeoutMillis, final int reconnectDelayMillis, final boolean immediateFail, final Layout<? extends Serializable> layout, final int bufferSize) { return getSocketManager(sslConfig, host, port, connectTimeoutMillis, reconnectDelayMillis, immediateFail, layout, bufferSize, null); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/614b9a7f/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java index d7d210e..4d263c4 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java @@ -164,8 +164,8 @@ public class TcpSocketManager extends AbstractSocketManager { * @deprecated Use {@link #getSocketManager(String, int, int, int, boolean, Layout, int, SocketOptions)}. */ @Deprecated - public static TcpSocketManager getSocketManager(final String host, int port, final int connectTimeoutMillis, - int reconnectDelayMillis, final boolean immediateFail, final Layout<? extends Serializable> layout, + public static TcpSocketManager getSocketManager(final String host, final int port, final int connectTimeoutMillis, + final int reconnectDelayMillis, final boolean immediateFail, final Layout<? extends Serializable> layout, final int bufferSize) { return getSocketManager(host, port, connectTimeoutMillis, reconnectDelayMillis, immediateFail, layout, bufferSize, null); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/614b9a7f/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java index 6881550..8b8983c 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java @@ -169,7 +169,7 @@ public final class PatternParser { } public List<PatternFormatter> parse(final String pattern, final boolean alwaysWriteExceptions, - boolean disableAnsi, final boolean noConsoleNoAnsi) { + final boolean disableAnsi, final boolean noConsoleNoAnsi) { final List<PatternFormatter> list = new ArrayList<>(); final List<PatternConverter> converters = new ArrayList<>(); final List<FormattingInfo> fields = new ArrayList<>(); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/614b9a7f/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java index e8d1053..0f17b9f 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java @@ -337,7 +337,7 @@ public class SocketAppenderTest { this(new ServerSocket(port)); } - public TcpSocketTestServer(ServerSocket serverSocket) { + public TcpSocketTestServer(final ServerSocket serverSocket) { this.serverSocket = serverSocket; this.queue = new ArrayBlockingQueue<>(10); }
