Repository: logging-log4j2 Updated Branches: refs/heads/master 5e92ed9fa -> 896d89963
Add missing '@Override' annotations. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/896d8996 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/896d8996 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/896d8996 Branch: refs/heads/master Commit: 896d89963be954dc466022a9040cc72c0512fdd4 Parents: 5e92ed9 Author: Gary Gregory <[email protected]> Authored: Thu Jul 6 03:06:50 2017 -0700 Committer: Gary Gregory <[email protected]> Committed: Thu Jul 6 03:06:50 2017 -0700 ---------------------------------------------------------------------- .../java/org/apache/logging/log4j/message/StringMapMessage.java | 1 + .../apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java | 1 + .../log4j/core/appender/rolling/DirectWriteRolloverStrategy.java | 1 + .../apache/logging/log4j/core/config/ConfigurationScheduler.java | 2 ++ .../java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java | 1 + .../java/org/apache/logging/log4j/core/impl/MutableLogEvent.java | 1 + .../java/org/apache/logging/log4j/core/pattern/NotANumber.java | 1 + 7 files changed, 8 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-api/src/main/java/org/apache/logging/log4j/message/StringMapMessage.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/StringMapMessage.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/StringMapMessage.java index 9c3ee18..9d05ce0 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/message/StringMapMessage.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/StringMapMessage.java @@ -64,6 +64,7 @@ public class StringMapMessage extends MapMessage<StringMapMessage, String> { * @param map The Map. * @return A new StringMapMessage */ + @Override public StringMapMessage newInstance(final Map<String, String> map) { return new StringMapMessage(map); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java index 52d21f4..697b37a 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java @@ -102,6 +102,7 @@ public class KafkaManager extends AbstractManager { response.get(timeoutMillis, TimeUnit.MILLISECONDS); } else { producer.send(newRecord, new Callback() { + @Override public void onCompletion(RecordMetadata metadata, Exception e) { if (e != null) { LOGGER.error("Unable to write to Kafka in appender [" + getName() + "]", e); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DirectWriteRolloverStrategy.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DirectWriteRolloverStrategy.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DirectWriteRolloverStrategy.java index 27d73c6..94bb9cb 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DirectWriteRolloverStrategy.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DirectWriteRolloverStrategy.java @@ -309,6 +309,7 @@ public class DirectWriteRolloverStrategy extends AbstractRolloverStrategy implem return eligibleFiles.size() > 0 ? eligibleFiles.lastKey() : 1; } + @Override public String getCurrentFileName(final RollingFileManager manager) { if (currentFileName == null) { SortedMap<Integer, Path> eligibleFiles = getEligibleFiles(manager); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationScheduler.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationScheduler.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationScheduler.java index 4839e75..60297f5 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationScheduler.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationScheduler.java @@ -239,11 +239,13 @@ public class ConfigurationScheduler extends AbstractLifeCycle { } } + @Override public String toString() { return "CronRunnable{" + cronExpression.getCronExpression() + " - " + scheduledFuture.getFireTime(); } } + @Override public String toString() { StringBuilder sb = new StringBuilder("ConfigurationScheduler {"); Queue<Runnable> queue = ((ScheduledThreadPoolExecutor) executorService).getQueue(); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java index d4fee68..21d906b 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java @@ -471,6 +471,7 @@ public class Log4jLogEvent implements LogEvent { return new Builder(this); } + @Override public Log4jLogEvent toImmutable() { if (getMessage() instanceof ReusableMessage) { makeMessageImmutable(); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MutableLogEvent.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MutableLogEvent.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MutableLogEvent.java index 542437a..051cad1 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MutableLogEvent.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MutableLogEvent.java @@ -75,6 +75,7 @@ public class MutableLogEvent implements LogEvent, ReusableMessage { this.parameters = replacementParameters; } + @Override public Log4jLogEvent toImmutable() { return createMemento(); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/896d8996/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NotANumber.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NotANumber.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NotANumber.java index 1468075..b8ab8c8 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NotANumber.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NotANumber.java @@ -26,6 +26,7 @@ public final class NotANumber { private NotANumber() { } + @Override public String toString() { return VALUE; }
