Repository: logging-log4j2 Updated Branches: refs/heads/master 96b1419ad -> 9fc8b7651
Add final modifier to private fields. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/39fb971d Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/39fb971d Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/39fb971d Branch: refs/heads/master Commit: 39fb971db3c276b4854254b5322b28e7165a8909 Parents: 96b1419 Author: Gary Gregory <[email protected]> Authored: Thu Jul 6 03:10:10 2017 -0700 Committer: Gary Gregory <[email protected]> Committed: Thu Jul 6 03:10:10 2017 -0700 ---------------------------------------------------------------------- .../log4j/message/ThreadDumpMessageTest.java | 2 +- .../core/util/datetime/FixedDateFormat.java | 2 +- .../core/appender/mom/JmsAppenderTest.java | 20 ++++++++++---------- 3 files changed, 12 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/39fb971d/log4j-api/src/test/java/org/apache/logging/log4j/message/ThreadDumpMessageTest.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/test/java/org/apache/logging/log4j/message/ThreadDumpMessageTest.java b/log4j-api/src/test/java/org/apache/logging/log4j/message/ThreadDumpMessageTest.java index e088234..451f712 100644 --- a/log4j-api/src/test/java/org/apache/logging/log4j/message/ThreadDumpMessageTest.java +++ b/log4j-api/src/test/java/org/apache/logging/log4j/message/ThreadDumpMessageTest.java @@ -144,7 +144,7 @@ public class ThreadDumpMessageTest { private class ThreadWithCountDownLatch extends Thread { private final CountDownLatch started; - private CountDownLatch keepAlive; + private final CountDownLatch keepAlive; volatile boolean finished; public ThreadWithCountDownLatch(final CountDownLatch started, final CountDownLatch keepAlive) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/39fb971d/log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java index 9c18c57..671725d 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/util/datetime/FixedDateFormat.java @@ -195,7 +195,7 @@ public class FixedDateFormat { private volatile long midnightToday = 0; private volatile long midnightTomorrow = 0; - private int[] dstOffsets = new int[25]; + private final int[] dstOffsets = new int[25]; // cachedDate does not need to be volatile because // there is a write to a volatile field *after* cachedDate is modified, http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/39fb971d/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/JmsAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/JmsAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/JmsAppenderTest.java index e53ac5a..d48167e 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/JmsAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/JmsAppenderTest.java @@ -61,16 +61,16 @@ public class JmsAppenderTest { private static final String TOPIC_NAME = "jms/topic"; private static final String LOG_MESSAGE = "Hello, world!"; - private ConnectionFactory connectionFactory = mock(ConnectionFactory.class); - private Connection connection = mock(Connection.class); - private Session session = mock(Session.class); - private Destination destination = mock(Destination.class); - private MessageProducer messageProducer = mock(MessageProducer.class); - private TextMessage textMessage = mock(TextMessage.class); - private ObjectMessage objectMessage = mock(ObjectMessage.class); - - private JndiRule jndiRule = new JndiRule(createBindings()); - private LoggerContextRule ctx = new LoggerContextRule("JmsAppenderTest.xml"); + private final ConnectionFactory connectionFactory = mock(ConnectionFactory.class); + private final Connection connection = mock(Connection.class); + private final Session session = mock(Session.class); + private final Destination destination = mock(Destination.class); + private final MessageProducer messageProducer = mock(MessageProducer.class); + private final TextMessage textMessage = mock(TextMessage.class); + private final ObjectMessage objectMessage = mock(ObjectMessage.class); + + private final JndiRule jndiRule = new JndiRule(createBindings()); + private final LoggerContextRule ctx = new LoggerContextRule("JmsAppenderTest.xml"); @Rule public RuleChain rules = RuleChain.outerRule(jndiRule).around(ctx);
