Refactor: removed code in RollingFileAppenderTest.cs that is commented out After all we have the file versioned and can bring that code back anytime we want.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4net/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4net/commit/3c6ec8bb Tree: http://git-wip-us.apache.org/repos/asf/logging-log4net/tree/3c6ec8bb Diff: http://git-wip-us.apache.org/repos/asf/logging-log4net/diff/3c6ec8bb Branch: refs/heads/develop Commit: 3c6ec8bb87140be7707a02ed43aed425cee0a2b9 Parents: c6391ae Author: Dominik Psenner <[email protected]> Authored: Thu Jul 27 17:31:10 2017 +0200 Committer: Dominik Psenner <[email protected]> Committed: Thu Jul 27 17:31:10 2017 +0200 ---------------------------------------------------------------------- tests/src/Appender/RollingFileAppenderTest.cs | 55 ---------------------- 1 file changed, 55 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4net/blob/3c6ec8bb/tests/src/Appender/RollingFileAppenderTest.cs ---------------------------------------------------------------------- diff --git a/tests/src/Appender/RollingFileAppenderTest.cs b/tests/src/Appender/RollingFileAppenderTest.cs index 25d4fa5..07ebfec 100644 --- a/tests/src/Appender/RollingFileAppenderTest.cs +++ b/tests/src/Appender/RollingFileAppenderTest.cs @@ -518,27 +518,6 @@ namespace log4net.Tests.Appender _iMessagesLoggedThisFile++; } - //private void DumpFileEntry( RollFileEntry entry ) - //{ - // System.Diagnostics.Debug.WriteLine( "\tfile name: " + entry.FileName ); - // System.Diagnostics.Debug.WriteLine( "\tfile length: " + entry.FileLength ); - //} - - //private void DumpTableEntry( RollConditions entry ) - //{ - // System.Diagnostics.Debug.WriteLine( "Pre-Conditions" ); - // foreach( RollFileEntry file in entry.GetPreLogFileEntries() ) - // { - // DumpFileEntry( file ); - // } - // System.Diagnostics.Debug.WriteLine( "Post-Conditions" ); - // foreach( RollFileEntry file in entry.GetPostLogFileEntries() ) - // { - // DumpFileEntry( file ); - // } - // // System.Diagnostics.Debug.WriteLine(""); - //} - /// <summary> /// Runs through all table entries, logging messages. Before each message is logged, /// pre-conditions are checked to ensure the expected files exist and they are the @@ -650,40 +629,6 @@ namespace log4net.Tests.Appender return sGroups[iGroup]; } - ///// <summary> - ///// Builds a collection of file entries based on the file names - ///// specified in a groups string and the max file size from the - ///// stats object - ///// </summary> - ///// <param name="sBackupGroups"></param> - ///// <param name="stats"></param> - ///// <returns></returns> - //private RollFileEntry[] MakeBackupFileEntriesForPreCondition( string sBackupGroups, RollingStats stats ) - //{ - // if (0 == stats.NumberOfFileRolls ) - // { - // return null; // first round has no previous backups - // } - // string sGroup; - // if (0 == stats.MessagesThisFile ) - // { - // // first file has special pattern...since rolling doesn't occur when message - // // is logged, rather before next message is logged. - // if (stats.NumberOfFileRolls <= 1 ) - // { - // return null; - // } - // // Use backup files from previous round. The minus 2 is because we have already - // // rolled, and the first round uses null instead of the string - // sGroup = GetBackupGroup( sBackupGroups, stats.NumberOfFileRolls-2 ); - // } - // else - // { - // sGroup = GetBackupGroup( sBackupGroups, stats.NumberOfFileRolls-1 ); - // } - // return MakeBackupFileEntriesFromBackupGroup( sGroup, stats.MaximumFileSize ); - //} - /// <summary> /// Builds a collection of file entries based on the file names /// specified in a groups string and the max file size from the
