Repository: logging-log4j-tools
Updated Branches:
  refs/heads/master f165ab9ba -> 5c06888bd


[LOG4J2-1994] TcpSocketServer does not close accepted Sockets. Comment.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j-tools/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/logging-log4j-tools/commit/5c06888b
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j-tools/tree/5c06888b
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j-tools/diff/5c06888b

Branch: refs/heads/master
Commit: 5c06888bd7086d7912d8a7411f99846e5f3641e2
Parents: f165ab9
Author: Gary Gregory <[email protected]>
Authored: Fri Jul 28 16:11:00 2017 -0700
Committer: Gary Gregory <[email protected]>
Committed: Fri Jul 28 16:11:00 2017 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/logging/log4j/server/TcpSocketServer.java  | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j-tools/blob/5c06888b/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
----------------------------------------------------------------------
diff --git 
a/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
 
b/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
index af458f8..7fde56b 100644
--- 
a/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
+++ 
b/log4j-server/src/main/java/org/apache/logging/log4j/server/TcpSocketServer.java
@@ -346,6 +346,7 @@ public class TcpSocketServer<T extends InputStream> extends 
AbstractSocketServer
             try {
                 // Accept incoming connections.
                 logger.debug("Listening for a connection {}...", serverSocket);
+                @SuppressWarnings("resource") // clientSocket is closed during 
SocketHandler shutdown
                 final Socket clientSocket = serverSocket.accept();
                 logger.debug("Acepted connection on {}...", serverSocket);
                 logger.debug("Socket accepted: {}", clientSocket);

Reply via email to