Repository: logging-log4j2 Updated Branches: refs/heads/master a82bc4990 -> 67cb5fff3
Don't need to nest in else clause. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/67cb5fff Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/67cb5fff Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/67cb5fff Branch: refs/heads/master Commit: 67cb5fff34fa8c7d32042725261d9d18f6a7db92 Parents: a82bc49 Author: Gary Gregory <ggreg...@apache.org> Authored: Thu Jan 4 12:02:43 2018 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Thu Jan 4 12:02:43 2018 -0700 ---------------------------------------------------------------------- .../log4j/spi/AbstractLoggerAdapter.java | 21 ++++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/67cb5fff/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerAdapter.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerAdapter.java b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerAdapter.java index a3eb31d..e86f990 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerAdapter.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLoggerAdapter.java @@ -70,18 +70,17 @@ public abstract class AbstractLoggerAdapter<L> implements LoggerAdapter<L> { if (loggers != null) { return loggers; - } else { - lock.writeLock ().lock (); - try { - loggers = registry.get (context); - if (loggers == null) { - loggers = new ConcurrentHashMap<> (); - registry.put (context, loggers); - } - return loggers; - } finally { - lock.writeLock ().unlock (); + } + lock.writeLock ().lock (); + try { + loggers = registry.get (context); + if (loggers == null) { + loggers = new ConcurrentHashMap<> (); + registry.put (context, loggers); } + return loggers; + } finally { + lock.writeLock ().unlock (); } }
