Repository: logging-log4j2
Updated Branches:
  refs/heads/master 33956aa61 -> d3d7f756f


Add // TODO Consider refactoring to use
AbstractFilter.AbstractFilterBuilder.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d3d7f756
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d3d7f756
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d3d7f756

Branch: refs/heads/master
Commit: d3d7f756f48b03eb3934c813f298092ef4425bd6
Parents: 33956aa
Author: Gary Gregory <[email protected]>
Authored: Wed Jan 24 13:51:19 2018 -0700
Committer: Gary Gregory <[email protected]>
Committed: Wed Jan 24 13:51:19 2018 -0700

----------------------------------------------------------------------
 .../apache/logging/log4j/core/filter/DynamicThresholdFilter.java    | 1 +
 .../java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java | 1 +
 .../main/java/org/apache/logging/log4j/core/filter/MapFilter.java   | 1 +
 .../java/org/apache/logging/log4j/core/filter/MarkerFilter.java     | 1 +
 .../main/java/org/apache/logging/log4j/core/filter/RegexFilter.java | 1 +
 .../java/org/apache/logging/log4j/core/filter/ScriptFilter.java     | 1 +
 .../org/apache/logging/log4j/core/filter/StructuredDataFilter.java  | 1 +
 .../apache/logging/log4j/core/filter/ThreadContextMapFilter.java    | 1 +
 .../java/org/apache/logging/log4j/core/filter/ThresholdFilter.java  | 1 +
 .../main/java/org/apache/logging/log4j/core/filter/TimeFilter.java  | 1 +
 10 files changed, 10 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
index 92a8433..923a39c 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/DynamicThresholdFilter.java
@@ -56,6 +56,7 @@ public final class DynamicThresholdFilter extends 
AbstractFilter {
      * @param onMismatch The action to perform if no match occurs.
      * @return The DynamicThresholdFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static DynamicThresholdFilter createFilter(
             @PluginAttribute("key") final String key,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
index 8f4769c..461998d 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/LevelRangeFilter.java
@@ -55,6 +55,7 @@ public final class LevelRangeFilter extends AbstractFilter {
      *            The action to take on a mismatch.
      * @return The created ThresholdFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static LevelRangeFilter createFilter(
             // @formatter:off

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
index de17256..39f3f14 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MapFilter.java
@@ -234,6 +234,7 @@ public class MapFilter extends AbstractFilter {
         return map;
     }
 
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static MapFilter createFilter(
             @PluginElement("Pairs") final KeyValuePair[] pairs,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
index 3950bc9..b828e31 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/MarkerFilter.java
@@ -152,6 +152,7 @@ public final class MarkerFilter extends AbstractFilter {
      * @param mismatch The action to take if no match occurs.
      * @return A MarkerFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static MarkerFilter createFilter(
             @PluginAttribute(ATTR_MARKER) final String marker,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java
index 0e20ab0..bef9888 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java
@@ -118,6 +118,7 @@ public final class RegexFilter extends AbstractFilter {
      * @throws IllegalAccessException
      * @throws IllegalArgumentException
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static RegexFilter createFilter(
             //@formatter:off

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ScriptFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ScriptFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ScriptFilter.java
index 5443906..1e47d4e 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ScriptFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ScriptFilter.java
@@ -130,6 +130,7 @@ public final class ScriptFilter extends AbstractFilter {
      * @param configuration the configuration 
      * @return A ScriptFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static ScriptFilter createFilter(
             @PluginElement("Script") final AbstractScript script,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StructuredDataFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StructuredDataFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StructuredDataFilter.java
index c759103..01015d4 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StructuredDataFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/StructuredDataFilter.java
@@ -154,6 +154,7 @@ public final class StructuredDataFilter extends MapFilter {
      * @param mismatch The action to perform on a mismatch.
      * @return The StructuredDataFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static StructuredDataFilter createFilter(
             @PluginElement("Pairs") final KeyValuePair[] pairs,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.java
index f4613f1..7f11e32 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.java
@@ -194,6 +194,7 @@ public class ThreadContextMapFilter extends MapFilter {
         return filter();
     }
 
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static ThreadContextMapFilter createFilter(
             @PluginElement("Pairs") final KeyValuePair[] pairs,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThresholdFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThresholdFilter.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThresholdFilter.java
index 641cb66..daa7a6e 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThresholdFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/ThresholdFilter.java
@@ -159,6 +159,7 @@ public final class ThresholdFilter extends AbstractFilter {
      * @param mismatch The action to take on a mismatch.
      * @return The created ThresholdFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static ThresholdFilter createFilter(
             @PluginAttribute("level") final Level level,

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d3d7f756/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/TimeFilter.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/TimeFilter.java 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/TimeFilter.java
index e05ef19..d75ae58 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/TimeFilter.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/TimeFilter.java
@@ -226,6 +226,7 @@ public final class TimeFilter extends AbstractFilter {
      * @param mismatch Action to perform if the action does not match.
      * @return A TimeFilter.
      */
+    // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
     @PluginFactory
     public static TimeFilter createFilter(
             @PluginAttribute("start") final String start,

Reply via email to