This is an automated email from the ASF dual-hosted git repository. rgoers pushed a commit to branch release-2.x in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 154c239d7769747996bc252f8525d01f007d8ba6 Author: Ralph Goers <[email protected]> AuthorDate: Sat Dec 4 22:44:01 2021 -0700 Convert method to return a boolean --- .../logging/log4j/core/pattern/MessagePatternConverter.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java index 41ab46b..1b6a584 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MessagePatternConverter.java @@ -46,16 +46,15 @@ public class MessagePatternConverter extends LogEventPatternConverter { super("Message", "message"); } - private static int loadLookups(final String[] options) { + private static boolean loadLookups(final String[] options) { if (options != null) { - for (int i = 0; i < options.length; i++) { - final String option = options[i]; + for (final String option : options) { if (LOOKUPS.equalsIgnoreCase(option)) { - return i; + return true; } } } - return -1; + return false; } private static TextRenderer loadMessageRenderer(final String[] options) { @@ -87,7 +86,7 @@ public class MessagePatternConverter extends LogEventPatternConverter { * @return instance of pattern converter. */ public static MessagePatternConverter newInstance(final Configuration config, final String[] options) { - boolean lookups = loadLookups(options) >= 0; + boolean lookups = loadLookups(options); String[] formats = withoutLookupOptions(options); TextRenderer textRenderer = loadMessageRenderer(formats); MessagePatternConverter result = formats == null || formats.length == 0
