This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch release-2.x in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit deb4e774ab2528fbef817bdf41a957dbf55db4d7 Author: Gary Gregory <[email protected]> AuthorDate: Wed Jan 19 08:01:44 2022 -0500 Define and reuse constant. --- .../apache/logging/log4j/core/appender/rolling/PatternProcessor.java | 3 +-- .../java/org/apache/logging/log4j/core/pattern/FormattingInfo.java | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java index 0bfa3d1..89d5266 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessor.java @@ -83,8 +83,7 @@ public class PatternProcessor { final List<PatternConverter> converters = new ArrayList<>(); final List<FormattingInfo> fields = new ArrayList<>(); parser.parse(pattern, converters, fields, false, false, false); - final FormattingInfo[] infoArray = new FormattingInfo[fields.size()]; - patternFields = fields.toArray(infoArray); + patternFields = fields.toArray(FormattingInfo.EMPTY_ARRAY); final ArrayPatternConverter[] converterArray = new ArrayPatternConverter[converters.size()]; patternConverters = converters.toArray(converterArray); this.fileExtension = FileExtension.lookupForFile(pattern); diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/FormattingInfo.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/FormattingInfo.java index bd88679..fa2019f 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/FormattingInfo.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/FormattingInfo.java @@ -65,6 +65,11 @@ public final class FormattingInfo { private final boolean zeroPad; /** + * Empty array. + */ + public static final FormattingInfo[] EMPTY_ARRAY = {}; + + /** * Creates new instance. * * @param leftAlign
