This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
The following commit(s) were added to refs/heads/release-2.x by this push:
new c77ae68 Refactor magic strings into test constants.
c77ae68 is described below
commit c77ae68701c4de965eb56482d640435f6bce5d89
Author: Gary Gregory <[email protected]>
AuthorDate: Mon Feb 7 09:29:05 2022 -0500
Refactor magic strings into test constants.
---
.../org/apache/logging/log4j/mongodb4/MongoDb4AuthFailureTest.java | 4 ++--
.../java/org/apache/logging/log4j/mongodb4/MongoDb4CappedTest.java | 4 ++--
.../org/apache/logging/log4j/mongodb4/MongoDb4MapMessageTest.java | 4 ++--
.../src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Test.java | 4 ++--
.../java/org/apache/logging/log4j/mongodb4/MongoDb4TestConstants.java | 2 ++
5 files changed, 10 insertions(+), 8 deletions(-)
diff --git
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4AuthFailureTest.java
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4AuthFailureTest.java
index c84d108..c13a16f 100644
---
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4AuthFailureTest.java
+++
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4AuthFailureTest.java
@@ -61,9 +61,9 @@ public class MongoDb4AuthFailureTest {
final Logger logger = LogManager.getLogger();
logger.info("Hello log");
try (final MongoClient mongoClient = mongoDbTestRule.getMongoClient())
{
- final MongoDatabase database = mongoClient.getDatabase("testDb");
+ final MongoDatabase database =
mongoClient.getDatabase(MongoDb4TestConstants.DATABASE_NAME);
Assert.assertNotNull(database);
- final MongoCollection<Document> collection =
database.getCollection("testCollection");
+ final MongoCollection<Document> collection =
database.getCollection(MongoDb4TestConstants.COLLECTION_NAME);
Assert.assertNotNull(collection);
final Document first = collection.find().first();
Assert.assertNull(first);
diff --git
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4CappedTest.java
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4CappedTest.java
index fcd7cd7..8e18f1a 100644
---
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4CappedTest.java
+++
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4CappedTest.java
@@ -57,9 +57,9 @@ public class MongoDb4CappedTest {
final Logger logger = LogManager.getLogger();
logger.info("Hello log");
try (final MongoClient mongoClient = mongoDbTestRule.getMongoClient())
{
- final MongoDatabase database = mongoClient.getDatabase("testDb");
+ final MongoDatabase database =
mongoClient.getDatabase(MongoDb4TestConstants.DATABASE_NAME);
Assert.assertNotNull(database);
- final MongoCollection<Document> collection =
database.getCollection("testCollection");
+ final MongoCollection<Document> collection =
database.getCollection(MongoDb4TestConstants.COLLECTION_NAME);
Assert.assertNotNull(collection);
final Document first = collection.find().first();
Assert.assertNotNull(first);
diff --git
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4MapMessageTest.java
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4MapMessageTest.java
index 70ab9a7..4665dd9 100644
---
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4MapMessageTest.java
+++
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4MapMessageTest.java
@@ -62,9 +62,9 @@ public class MongoDb4MapMessageTest {
logger.info(mapMessage);
//
try (final MongoClient mongoClient = mongoDbTestRule.getMongoClient())
{
- final MongoDatabase database = mongoClient.getDatabase("testDb");
+ final MongoDatabase database =
mongoClient.getDatabase(MongoDb4TestConstants.DATABASE_NAME);
Assert.assertNotNull(database);
- final MongoCollection<Document> collection =
database.getCollection("testCollection");
+ final MongoCollection<Document> collection =
database.getCollection(MongoDb4TestConstants.COLLECTION_NAME);
Assert.assertNotNull(collection);
final Document first = collection.find().first();
Assert.assertNotNull(first);
diff --git
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Test.java
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Test.java
index fa226b7..0f18bf0 100644
---
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Test.java
+++
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Test.java
@@ -59,9 +59,9 @@ public class MongoDb4Test {
logger.info("Hello log 1");
logger.info("Hello log 2", new RuntimeException("Hello ex 2"));
try (final MongoClient mongoClient = mongoDbTestRule.getMongoClient())
{
- final MongoDatabase database = mongoClient.getDatabase("testDb");
+ final MongoDatabase database =
mongoClient.getDatabase(MongoDb4TestConstants.DATABASE_NAME);
Assert.assertNotNull(database);
- final MongoCollection<Document> collection =
database.getCollection("testCollection");
+ final MongoCollection<Document> collection =
database.getCollection(MongoDb4TestConstants.COLLECTION_NAME);
Assert.assertNotNull(collection);
final FindIterable<Document> found = collection.find();
final Document first = found.first();
diff --git
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4TestConstants.java
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4TestConstants.java
index 0d398f0..5b4e64c 100644
---
a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4TestConstants.java
+++
b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4TestConstants.java
@@ -20,5 +20,7 @@ package org.apache.logging.log4j.mongodb4;
public class MongoDb4TestConstants {
public static final String SYS_PROP_NAME_PORT = "MongoDBTestPort";
+ static final String COLLECTION_NAME = "testCollection";
+ static final String DATABASE_NAME = "testDb";
}
