This is an automated email from the ASF dual-hosted git repository.

mattsicker pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit f7f715db9950d9cca765c25e95a846d0f4329d71
Author: Matt Sicker <[email protected]>
AuthorDate: Mon Jun 20 17:26:38 2022 -0500

    Throw IllegalArgumentException earlier
    
    This avoids some potential NullPointerExceptions according to static code 
analysis.
    
    Signed-off-by: Matt Sicker <[email protected]>
---
 .../main/java/org/apache/logging/log4j/core/util/CronExpression.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/util/CronExpression.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/util/CronExpression.java
index c5423cf852..39a95dd15b 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/util/CronExpression.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/util/CronExpression.java
@@ -1098,7 +1098,7 @@ public final class CronExpression {
             case YEAR:
                 return years;
             default:
-                return null;
+                throw new IllegalArgumentException("Unexpected type: " + type);
         }
     }
 

Reply via email to