[logging-log4cxx] branch next_stable updated: Create default virtual destructors to destroy correctly

[rmiddleton]

This is an automated email from the ASF dual-hosted git repository.

rmiddleton pushed a commit to branch next_stable
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git


The following commit(s) were added to refs/heads/next_stable by this push:
     new a46055a6 Create default virtual destructors to destroy correctly
a46055a6 is described below

commit a46055a65b29e828d5bf85c2595031f78672b429
Author: Robert Middleton <robert.middle...@rm5248.com>
AuthorDate: Sat Nov 19 14:58:50 2022 -0500

    Create default virtual destructors to destroy correctly
---
 src/main/include/log4cxx/private/action_priv.h           | 2 ++
 src/main/include/log4cxx/private/appenderskeleton_priv.h | 2 ++
 src/main/include/log4cxx/private/filter_priv.h           | 2 ++
 src/main/include/log4cxx/private/patternconverter_priv.h | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/src/main/include/log4cxx/private/action_priv.h 
b/src/main/include/log4cxx/private/action_priv.h
index d5dea924..d77de4b3 100644
--- a/src/main/include/log4cxx/private/action_priv.h
+++ b/src/main/include/log4cxx/private/action_priv.h
@@ -31,6 +31,8 @@ struct Action::ActionPrivate
                interrupted(false),
                pool() {}
 
+       virtual ~ActionPrivate(){}
+
        /**
         * Is action complete.
         */
diff --git a/src/main/include/log4cxx/private/appenderskeleton_priv.h 
b/src/main/include/log4cxx/private/appenderskeleton_priv.h
index 4a6b8318..67b271f3 100644
--- a/src/main/include/log4cxx/private/appenderskeleton_priv.h
+++ b/src/main/include/log4cxx/private/appenderskeleton_priv.h
@@ -38,6 +38,8 @@ struct AppenderSkeleton::AppenderSkeletonPrivate
                
errorHandler(std::make_shared<log4cxx::helpers::OnlyOnceErrorHandler>()),
                closed(false) {}
 
+       virtual ~AppenderSkeletonPrivate(){}
+
        /** The layout variable does not need to be set if the appender
        implementation has its own layout. */
        LayoutPtr layout;
diff --git a/src/main/include/log4cxx/private/filter_priv.h 
b/src/main/include/log4cxx/private/filter_priv.h
index fb9b0865..672458b5 100644
--- a/src/main/include/log4cxx/private/filter_priv.h
+++ b/src/main/include/log4cxx/private/filter_priv.h
@@ -26,6 +26,8 @@ namespace spi
 
 struct Filter::FilterPrivate
 {
+       virtual ~FilterPrivate(){}
+
        /**
        Points to the next filter in the filter chain.
        */
diff --git a/src/main/include/log4cxx/private/patternconverter_priv.h 
b/src/main/include/log4cxx/private/patternconverter_priv.h
index fedaaaa8..124a11be 100644
--- a/src/main/include/log4cxx/private/patternconverter_priv.h
+++ b/src/main/include/log4cxx/private/patternconverter_priv.h
@@ -34,6 +34,8 @@ struct PatternConverter::PatternConverterPrivate
                name(_name),
                style(_style) {}
 
+       virtual ~PatternConverterPrivate(){}
+
        /**
         * Converter name.
         */