This is an automated email from the ASF dual-hosted git repository.

mattsicker pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit 85d3a9832d07e7edb71398501802ad46a503e5f3
Author: Matt Sicker <[email protected]>
AuthorDate: Sun Oct 15 19:30:21 2023 -0500

    Fix NPE in AbstractFilterable::removeFilter
    
    Signed-off-by: Matt Sicker <[email protected]>
---
 .../java/org/apache/logging/log4j/core/filter/AbstractFilterable.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/AbstractFilterable.java
 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/AbstractFilterable.java
index 0a8b3d6dbd..3bc1dc9e86 100644
--- 
a/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/AbstractFilterable.java
+++ 
b/log4j-core/src/main/java/org/apache/logging/log4j/core/filter/AbstractFilterable.java
@@ -157,7 +157,7 @@ public abstract class AbstractFilterable extends 
AbstractLifeCycle implements Fi
         filterLock.lock();
         try {
             final var currentFilter = this.filter;
-            if (currentFilter == filter || currentFilter.equals(filter)) {
+            if (currentFilter == filter || filter.equals(currentFilter)) {
                 this.filter = null;
             } else if (currentFilter instanceof CompositeFilter) {
                 CompositeFilter composite = (CompositeFilter) currentFilter;

Reply via email to