(logging-chainsaw) branch master updated: simplified code, typo, keyword order

[grobmeier]

This is an automated email from the ASF dual-hosted git repository.

grobmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git


The following commit(s) were added to refs/heads/master by this push:
     new c73f27b  simplified code, typo, keyword order
c73f27b is described below

commit c73f27bffe445c237e79745f84c6d391fe46353b
Author: Christian Grobmeier <c...@grobmeier.de>
AuthorDate: Sat Dec 2 17:00:01 2023 +0100

    simplified code, typo, keyword order
---
 .../org/apache/log4j/chainsaw/help/HelpLocator.java     | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/main/java/org/apache/log4j/chainsaw/help/HelpLocator.java 
b/src/main/java/org/apache/log4j/chainsaw/help/HelpLocator.java
index cd1ba79..e97bfa2 100644
--- a/src/main/java/org/apache/log4j/chainsaw/help/HelpLocator.java
+++ b/src/main/java/org/apache/log4j/chainsaw/help/HelpLocator.java
@@ -35,8 +35,8 @@ import java.util.List;
  * &lt;psm...@apache.org&gt;
  */
 class HelpLocator {
-    private List<ClassLoader> classLoaders = new ArrayList<>();
-    private final static Logger logger = 
LogManager.getLogger(HelpLocator.class);
+    private final List<ClassLoader> classLoaders = new ArrayList<>();
+    private static final Logger logger = 
LogManager.getLogger(HelpLocator.class);
 
     /**
      * Adds a ClassLoader to be used as a help resource locator
@@ -55,7 +55,7 @@ class HelpLocator {
             classLoaders.add(new HelpResourceLoader(url));
         } catch (Exception e) {
             logger.error(
-                "Failed to setup the resoure loaders for the Help Subsystem");
+                "Failed to setup the resource loaders for the Help Subsystem");
         }
     }
 
@@ -65,18 +65,15 @@ class HelpLocator {
      * @return URL of the located resource, or null if it cannot be located.
      */
     URL findResource(String name) {
-        URL url = null;
-
-        for (Object classLoader : classLoaders) {
-            ClassLoader loader = (ClassLoader) classLoader;
-            url = loader.getResource(name);
+        for (ClassLoader classLoader : classLoaders) {
+            URL url = classLoader.getResource(name);
 
             if (url != null) {
-                break;
+                return url;
             }
         }
 
-        return url;
+        return null;
     }
 
     private static class HelpResourceLoader extends ClassLoader {