This is an automated email from the ASF dual-hosted git repository. mattsicker pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 8cabcabf21da3993d35d0dd00068e6c9b5ad07f8 Author: Matt Sicker <[email protected]> AuthorDate: Mon Jan 1 18:17:05 2024 -0600 Make MongoDb4Resolver use standard abstract class JUnit has since created a `TypeBasedParameterResolver<T>` abstract class which we can use. Signed-off-by: Matt Sicker <[email protected]> --- .../java/org/apache/logging/log4j/mongodb4/MongoDb4Resolver.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Resolver.java b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Resolver.java index 379137212e..03ca4188b4 100644 --- a/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Resolver.java +++ b/log4j-mongodb4/src/test/java/org/apache/logging/log4j/mongodb4/MongoDb4Resolver.java @@ -46,12 +46,12 @@ import org.apache.logging.log4j.status.StatusLogger; import org.apache.logging.log4j.test.TestProperties; import org.apache.logging.log4j.test.junit.ExtensionContextAnchor; import org.apache.logging.log4j.test.junit.TestPropertySource; -import org.apache.logging.log4j.test.junit.TypeBasedParameterResolver; import org.junit.jupiter.api.extension.BeforeAllCallback; import org.junit.jupiter.api.extension.ExtensionContext; import org.junit.jupiter.api.extension.ExtensionContext.Store.CloseableResource; import org.junit.jupiter.api.extension.ParameterContext; import org.junit.jupiter.api.extension.ParameterResolutionException; +import org.junit.jupiter.api.extension.support.TypeBasedParameterResolver; public class MongoDb4Resolver extends TypeBasedParameterResolver<MongoClient> implements BeforeAllCallback { @@ -79,10 +79,6 @@ public class MongoDb4Resolver extends TypeBasedParameterResolver<MongoClient> im throw new NotImplementedException(loggingTarget.toString()); } - public MongoDb4Resolver() { - super(MongoClient.class); - } - @Override public void beforeAll(ExtensionContext context) throws Exception { final TestProperties props = TestPropertySource.createProperties(context); @@ -125,7 +121,7 @@ public class MongoDb4Resolver extends TypeBasedParameterResolver<MongoClient> im @Override public MongoClient resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException { - return ExtensionContextAnchor.getAttribute(MongoClientHolder.class, MongoClientHolder.class, extensionContext) + return ExtensionContextAnchor.getRequiredAttribute(MongoClientHolder.class, MongoClientHolder.class, extensionContext) .get(); }
