This is an automated email from the ASF dual-hosted git repository.

swebb2066 pushed a commit to branch speed_up_tests
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git

commit ea2aa79a95aeaa48b62c7c1cc2700efee7d04f62
Author: Stephen Webb <[email protected]>
AuthorDate: Sun Jan 7 17:59:35 2024 +1100

    Remove unnecessary delays in unit tests
---
 src/test/cpp/vectorappender.cpp | 6 +++---
 src/test/cpp/vectorappender.h   | 9 +++++++--
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/test/cpp/vectorappender.cpp b/src/test/cpp/vectorappender.cpp
index 13fa5656..e01dbad8 100644
--- a/src/test/cpp/vectorappender.cpp
+++ b/src/test/cpp/vectorappender.cpp
@@ -25,9 +25,9 @@ IMPLEMENT_LOG4CXX_OBJECT(VectorAppender)
 
 void VectorAppender::append(const spi::LoggingEventPtr& event, Pool& /*p*/)
 {
-       std::this_thread::sleep_for( std::chrono::milliseconds( 100 ) );
-
-       vector.push_back(event);
+       if (0 < this->appendMillisecondDelay)
+               std::this_thread::sleep_for( std::chrono::milliseconds( 
this->appendMillisecondDelay ) );
+       this->vector.push_back(event);
 }
 
 void VectorAppender::close()
diff --git a/src/test/cpp/vectorappender.h b/src/test/cpp/vectorappender.h
index fe184dea..0d379fd4 100644
--- a/src/test/cpp/vectorappender.h
+++ b/src/test/cpp/vectorappender.h
@@ -37,7 +37,7 @@ class VectorAppender : public AppenderSkeleton
                END_LOG4CXX_CAST_MAP()
 
                std::vector<spi::LoggingEventPtr> vector;
-
+               int appendMillisecondDelay = 0;
 
                /**
                This method is called by the AppenderSkeleton#doAppend
@@ -47,7 +47,7 @@ class VectorAppender : public AppenderSkeleton
 
                const std::vector<spi::LoggingEventPtr>& getVector() const
                {
-                       return vector;
+                       return this->vector;
                }
 
                void close() override;
@@ -61,6 +61,11 @@ class VectorAppender : public AppenderSkeleton
                {
                        return false;
                }
+
+               void setMillisecondDelay(int milliseconds)
+               {
+                       this->appendMillisecondDelay = milliseconds;
+               }
 };
 typedef std::shared_ptr<VectorAppender> VectorAppenderPtr;
 }

Reply via email to