This is an automated email from the ASF dual-hosted git repository.
freeandnil pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git
The following commit(s) were added to refs/heads/master by this push:
new 2a013ea2 Removing username and password in SQL connection string to
prevent CodeQL rule id cs/password-in-configuration false positive
2a013ea2 is described below
commit 2a013ea2888288df969f70f76e9a3e84eb22450a
Author: Justin Michaels <[email protected]>
AuthorDate: Tue Jan 23 20:31:31 2024 -0500
Removing username and password in SQL connection string to prevent CodeQL
rule id cs/password-in-configuration false positive
---
examples/mono/1.0/Tutorials/ConsoleApp/cs/src/App.config | 2 +-
examples/net/1.1/Tutorials/ConsoleApp/cpp/src/App.config | 2 +-
examples/net/1.1/Tutorials/ConsoleApp/js/src/App.config | 2 +-
examples/net/2.0/Appenders/SampleAppendersApp/cs/src/App.config | 2 +-
examples/net/2.0/Tutorials/ConsoleApp/cs/src/App.config | 2 +-
examples/net/2.0/Tutorials/ConsoleApp/vb/src/App.config | 2 +-
src/log4net/Appender/AdoNetAppender.cs | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/examples/mono/1.0/Tutorials/ConsoleApp/cs/src/App.config
b/examples/mono/1.0/Tutorials/ConsoleApp/cs/src/App.config
index f312d5f2..93ce6110 100644
--- a/examples/mono/1.0/Tutorials/ConsoleApp/cs/src/App.config
+++ b/examples/mono/1.0/Tutorials/ConsoleApp/cs/src/App.config
@@ -145,7 +145,7 @@
<appender name="ADONetAppender_SqlServer"
type="log4net.Appender.AdoNetAppender">
<bufferSize value="1" />
<connectionType value="System.Data.SqlClient.SqlConnection,
System.Data, Version=1.0.3300.0, Culture=neutral,
PublicKeyToken=b77a5c561934e089" />
- <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;User
ID=sa;Password=sa" />
+ <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;" />
<commandText value="INSERT INTO Log
([Date],[Thread],[Level],[Logger],[Message]) VALUES (@log_date, @thread,
@log_level, @logger, @message)" />
<parameter>
<parameterName value="@log_date" />
diff --git a/examples/net/1.1/Tutorials/ConsoleApp/cpp/src/App.config
b/examples/net/1.1/Tutorials/ConsoleApp/cpp/src/App.config
index de78cf09..82dc979b 100644
--- a/examples/net/1.1/Tutorials/ConsoleApp/cpp/src/App.config
+++ b/examples/net/1.1/Tutorials/ConsoleApp/cpp/src/App.config
@@ -150,7 +150,7 @@
<appender name="ADONetAppender_SqlServer"
type="log4net.Appender.AdoNetAppender">
<bufferSize value="1" />
<connectionType
value="System.Data.SqlClient.SqlConnection, System.Data, Version=1.0.3300.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089" />
- <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;User
ID=sa;Password=sa" />
+ <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;" />
<commandText value="INSERT INTO Log
([Date],[Thread],[Level],[Logger],[Message]) VALUES (@log_date, @thread,
@log_level, @logger, @message)" />
<parameter>
<parameterName value="@log_date" />
diff --git a/examples/net/1.1/Tutorials/ConsoleApp/js/src/App.config
b/examples/net/1.1/Tutorials/ConsoleApp/js/src/App.config
index dca56a76..4b7bba22 100644
--- a/examples/net/1.1/Tutorials/ConsoleApp/js/src/App.config
+++ b/examples/net/1.1/Tutorials/ConsoleApp/js/src/App.config
@@ -150,7 +150,7 @@
<appender name="ADONetAppender_SqlServer"
type="log4net.Appender.AdoNetAppender">
<bufferSize value="1" />
<connectionType
value="System.Data.SqlClient.SqlConnection, System.Data, Version=1.0.3300.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089" />
- <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;User
ID=sa;Password=sa" />
+ <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;" />
<commandText value="INSERT INTO Log
([Date],[Thread],[Level],[Logger],[Message]) VALUES (@log_date, @thread,
@log_level, @logger, @message)" />
<parameter>
<parameterName value="@log_date" />
diff --git a/examples/net/2.0/Appenders/SampleAppendersApp/cs/src/App.config
b/examples/net/2.0/Appenders/SampleAppendersApp/cs/src/App.config
index 7016b3c6..33e306e9 100644
--- a/examples/net/2.0/Appenders/SampleAppendersApp/cs/src/App.config
+++ b/examples/net/2.0/Appenders/SampleAppendersApp/cs/src/App.config
@@ -96,7 +96,7 @@
</appender>
<appender name="FastDbAppender"
type="SampleAppendersApp.Appender.FastDbAppender, SampleAppendersApp">
- <connectionString value="Persist Security
Info=False;Integrated Security=false;server=ate;database=log4net_test;Connect
Timeout=30;User ID=sa;Password=sa" />
+ <connectionString value="Persist Security
Info=False;Integrated Security=false;server=ate;database=log4net_test;Connect
Timeout=30;" />
</appender>
<appender name="PatternFileAppender"
type="SampleAppendersApp.Appender.PatternFileAppender, SampleAppendersApp">
diff --git a/examples/net/2.0/Tutorials/ConsoleApp/cs/src/App.config
b/examples/net/2.0/Tutorials/ConsoleApp/cs/src/App.config
index f3d71025..a96ed7c4 100644
--- a/examples/net/2.0/Tutorials/ConsoleApp/cs/src/App.config
+++ b/examples/net/2.0/Tutorials/ConsoleApp/cs/src/App.config
@@ -150,7 +150,7 @@
<appender name="ADONetAppender_SqlServer"
type="log4net.Appender.AdoNetAppender">
<bufferSize value="1" />
<connectionType
value="System.Data.SqlClient.SqlConnection, System.Data, Version=1.0.3300.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089" />
- <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;User
ID=sa;Password=sa" />
+ <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;" />
<commandText value="INSERT INTO Log
([Date],[Thread],[Level],[Logger],[Message]) VALUES (@log_date, @thread,
@log_level, @logger, @message)" />
<parameter>
<parameterName value="@log_date" />
diff --git a/examples/net/2.0/Tutorials/ConsoleApp/vb/src/App.config
b/examples/net/2.0/Tutorials/ConsoleApp/vb/src/App.config
index f3d71025..a96ed7c4 100644
--- a/examples/net/2.0/Tutorials/ConsoleApp/vb/src/App.config
+++ b/examples/net/2.0/Tutorials/ConsoleApp/vb/src/App.config
@@ -150,7 +150,7 @@
<appender name="ADONetAppender_SqlServer"
type="log4net.Appender.AdoNetAppender">
<bufferSize value="1" />
<connectionType
value="System.Data.SqlClient.SqlConnection, System.Data, Version=1.0.3300.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089" />
- <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;User
ID=sa;Password=sa" />
+ <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;" />
<commandText value="INSERT INTO Log
([Date],[Thread],[Level],[Logger],[Message]) VALUES (@log_date, @thread,
@log_level, @logger, @message)" />
<parameter>
<parameterName value="@log_date" />
diff --git a/src/log4net/Appender/AdoNetAppender.cs
b/src/log4net/Appender/AdoNetAppender.cs
index b5d05842..c4e3e358 100644
--- a/src/log4net/Appender/AdoNetAppender.cs
+++ b/src/log4net/Appender/AdoNetAppender.cs
@@ -89,7 +89,7 @@ namespace log4net.Appender
/// <code lang="XML" escaped="true">
/// <appender name="AdoNetAppender_SqlServer"
type="log4net.Appender.AdoNetAppender" >
/// <connectionType value="System.Data.SqlClient.SqlConnection,
System.Data, Version=1.0.3300.0, Culture=neutral,
PublicKeyToken=b77a5c561934e089" />
- /// <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;User
ID=sa;Password=sa" />
+ /// <connectionString value="data source=SQLSVR;initial
catalog=test_log4net;integrated security=false;persist security info=True;" />
/// <commandText value="INSERT INTO Log
([Date],[Thread],[Level],[Logger],[Message]) VALUES (@log_date, @thread,
@log_level, @logger, @message)" />
/// <parameter>
/// <parameterName value="@log_date" />
