This is an automated email from the ASF dual-hosted git repository. mattsicker pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit f7e10092668d37923e42096f05d27c6674582708 Author: Matt Sicker <[email protected]> AuthorDate: Fri Feb 16 16:27:05 2024 -0600 Use instanceof casting --- .../log4j/plugins/util/OrderedComparator.java | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/OrderedComparator.java b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/OrderedComparator.java index efebb75062..cb3620765d 100644 --- a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/OrderedComparator.java +++ b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/OrderedComparator.java @@ -53,20 +53,20 @@ public class OrderedComparator implements Comparator<AnnotatedElement> { } private static String getName(final AnnotatedElement element) { - if (element instanceof Class<?>) { - return Keys.getName((Class<?>) element); + if (element instanceof Class<?> clazz) { + return Keys.getName(clazz); } - if (element instanceof Field) { - return Keys.getName((Field) element); + if (element instanceof Field field) { + return Keys.getName(field); } - if (element instanceof Parameter) { - return Keys.getName((Parameter) element); + if (element instanceof Parameter parameter) { + return Keys.getName(parameter); } - if (element instanceof Method) { - return Keys.getName((Method) element); + if (element instanceof Method method) { + return Keys.getName(method); } - if (element instanceof AnnotatedType) { - return Keys.getName((AnnotatedType) element); + if (element instanceof AnnotatedType annotatedType) { + return Keys.getName(annotatedType); } return Strings.EMPTY; }
