This is an automated email from the ASF dual-hosted git repository. freeandnil pushed a commit to branch Feature/133-nullable-Level in repository https://gitbox.apache.org/repos/asf/logging-log4net.git
commit 191705e70f67cf982901a47613387454f4a4e2b5 Author: Jan Friedrich <[email protected]> AuthorDate: Thu Mar 28 19:42:20 2024 +0100 #124 LoggingEvent.Level not nullable --- src/log4net.Tests/Util/CyclicBufferTest.cs | 10 +++++----- src/log4net/Core/ILogger.cs | 2 +- src/log4net/Core/LoggingEvent.cs | 4 ++-- src/log4net/Repository/Hierarchy/Logger.cs | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/log4net.Tests/Util/CyclicBufferTest.cs b/src/log4net.Tests/Util/CyclicBufferTest.cs index 9125d0cc..e726e390 100644 --- a/src/log4net.Tests/Util/CyclicBufferTest.cs +++ b/src/log4net.Tests/Util/CyclicBufferTest.cs @@ -46,8 +46,8 @@ namespace log4net.Tests.Util Assert.AreEqual(0, cb.Length, "Empty Buffer should have length 0"); Assert.AreEqual(1, cb.MaxSize, "Buffer should have max size 1"); - LoggingEvent event1 = new LoggingEvent(null, null, null, null, null, null); - LoggingEvent event2 = new LoggingEvent(null, null, null, null, null, null); + LoggingEvent event1 = new LoggingEvent(null, null, null, Level.All, null, null); + LoggingEvent event2 = new LoggingEvent(null, null, null, Level.All, null, null); LoggingEvent? discardedEvent = cb.Append(event1); @@ -77,9 +77,9 @@ namespace log4net.Tests.Util Assert.AreEqual(0, cb.Length, "Empty Buffer should have length 0"); Assert.AreEqual(2, cb.MaxSize, "Buffer should have max size 2"); - LoggingEvent event1 = new LoggingEvent(null, null, null, null, null, null); - LoggingEvent event2 = new LoggingEvent(null, null, null, null, null, null); - LoggingEvent event3 = new LoggingEvent(null, null, null, null, null, null); + LoggingEvent event1 = new LoggingEvent(null, null, null, Level.All, null, null); + LoggingEvent event2 = new LoggingEvent(null, null, null, Level.All, null, null); + LoggingEvent event3 = new LoggingEvent(null, null, null, Level.All, null, null); LoggingEvent? discardedEvent; diff --git a/src/log4net/Core/ILogger.cs b/src/log4net/Core/ILogger.cs index d3b513ad..06fcc842 100644 --- a/src/log4net/Core/ILogger.cs +++ b/src/log4net/Core/ILogger.cs @@ -57,7 +57,7 @@ namespace log4net.Core /// This generic form is intended to be used by wrappers. /// </para> /// </remarks> - void Log(Type callerStackBoundaryDeclaringType, Level? level, object? message, Exception? exception); + void Log(Type callerStackBoundaryDeclaringType, Level level, object? message, Exception? exception); /// <summary> /// Logs the specified logging event through this logger. diff --git a/src/log4net/Core/LoggingEvent.cs b/src/log4net/Core/LoggingEvent.cs index 9f67b967..cfd447f9 100644 --- a/src/log4net/Core/LoggingEvent.cs +++ b/src/log4net/Core/LoggingEvent.cs @@ -55,7 +55,7 @@ namespace log4net.Core /// Due to its special serialization it cannot be declared final either. /// </para> /// </remarks> - public Level? Level; + public Level Level; /// <summary> /// The application supplied message. @@ -239,7 +239,7 @@ namespace log4net.Core Type? callerStackBoundaryDeclaringType, ILoggerRepository? repository, string? loggerName, - Level? level, + Level level, object? message, Exception? exception) { diff --git a/src/log4net/Repository/Hierarchy/Logger.cs b/src/log4net/Repository/Hierarchy/Logger.cs index c946813d..75446206 100644 --- a/src/log4net/Repository/Hierarchy/Logger.cs +++ b/src/log4net/Repository/Hierarchy/Logger.cs @@ -350,7 +350,7 @@ namespace log4net.Repository.Hierarchy /// This method must not throw any exception to the caller. /// </para> /// </remarks> - public virtual void Log(Type? callerStackBoundaryDeclaringType, Level? level, object? message, Exception? exception) + public virtual void Log(Type? callerStackBoundaryDeclaringType, Level level, object? message, Exception? exception) { try { @@ -577,7 +577,7 @@ namespace log4net.Repository.Hierarchy /// appenders. /// </para> /// </remarks> - protected virtual void ForcedLog(Type callerStackBoundaryDeclaringType, Level? level, object? message, Exception? exception) + protected virtual void ForcedLog(Type callerStackBoundaryDeclaringType, Level level, object? message, Exception? exception) { CallAppenders(new LoggingEvent(callerStackBoundaryDeclaringType, Hierarchy, Name, level, message, exception)); }
