This is an automated email from the ASF dual-hosted git repository.
swebb2066 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git
The following commit(s) were added to refs/heads/master by this push:
new 36d829e9 Escape any thread name '&' or '"' in html attribute data
(#514)
36d829e9 is described below
commit 36d829e9f6c3f9f4f9a42e22df326a9ed7b6e373
Author: Stephen Webb <stephen.w...@ieee.org>
AuthorDate: Fri Jul 25 10:02:18 2025 +1000
Escape any thread name '&' or '"' in html attribute data (#514)
* Update change report
---
src/main/cpp/htmllayout.cpp | 4 ++--
src/site/markdown/change-report-gh.md | 22 ++++++++++++----------
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/main/cpp/htmllayout.cpp b/src/main/cpp/htmllayout.cpp
index cce9c1dc..f1b2747c 100644
--- a/src/main/cpp/htmllayout.cpp
+++ b/src/main/cpp/htmllayout.cpp
@@ -98,9 +98,9 @@ void HTMLLayout::format(LogString& output,
output.append(LOG4CXX_STR("<td title=\""));
LogString threadName(event->getThreadName());
- output.append(threadName);
+ Transform::appendEscapingTags(output, threadName);
output.append(LOG4CXX_STR(" thread\">"));
- output.append(threadName);
+ Transform::appendEscapingTags(output, threadName);
output.append(LOG4CXX_STR("</td>"));
output.append(LOG4CXX_EOL);
diff --git a/src/site/markdown/change-report-gh.md
b/src/site/markdown/change-report-gh.md
index 1a7d3b8e..485a7104 100644
--- a/src/site/markdown/change-report-gh.md
+++ b/src/site/markdown/change-report-gh.md
@@ -62,16 +62,18 @@ Release 1.5.0 includes the following new features:
The following issues have been addressed:
-* HTML output was illformed when the title contained the special HTML
characters
- \[[#513](https://github.com/apache/logging-log4cxx/issues/513)\]
-* JSON output illformed when a message contained certain control characters
- \[[#512](https://github.com/apache/logging-log4cxx/issues/512)\]
+* HTML output was illformed when the logger name, title or thread name
contained the special HTML characters
+ * [#509](https://github.com/apache/logging-log4cxx/pull/509)
+ , [#513](https://github.com/apache/logging-log4cxx/pull/513)
+ , [#514](https://github.com/apache/logging-log4cxx/pull/514)
+* JSON output was illformed when a message contained certain control characters
+ \[[#512](https://github.com/apache/logging-log4cxx/pull/512)\]
* Undefined behaviour when reloading a configuration file after calling
LogManager::shutdown
- \[[#504](https://github.com/apache/logging-log4cxx/issues/504)\]
+ \[[#504](https://github.com/apache/logging-log4cxx/pull/504)\]
* Compilation error when using gcc on MacOS
- \[[#499](https://github.com/apache/logging-log4cxx/issues/499)\]
+ \[[#499](https://github.com/apache/logging-log4cxx/pull/499)\]
* It was possible for logging events to be lost when reloading a configuration
file
- \[[#491](https://github.com/apache/logging-log4cxx/issues/491)\]
+ \[[#491](https://github.com/apache/logging-log4cxx/pull/491)\]
## Release 1.4.0 - 2025-03-01 {#rel_1_4_0}
@@ -557,9 +559,9 @@ AppenderPtr appender = log4cxx::cast<Appender>(instance);
|  | helpers/object.h: DECLARE\_LOG4CXX\_OBJECT
macro definition is missing virtual destructor declaration Fixes
[LOGCXX-160](https://issues.apache.org/jira/browse/LOGCXX-160).
| |
|  | Initialization of local static objects out of
order on Linux Fixes
[LOGCXX-159](https://issues.apache.org/jira/browse/LOGCXX-159).
| |
|  | tolower not defined in stringhelper.cpp Fixes
[LOGCXX-158](https://issues.apache.org/jira/browse/LOGCXX-158).
| |
-|  | make install fails since @manual\_dest@
replacement is missing in Makefiles Fixes
[LOGCXX-157](https://issues.apache.org/jira/browse/LOGCXX-157).
| |
-|  | immediate flush in console appender Fixes
[LOGCXX-156](https://issues.apache.org/jira/browse/LOGCXX-156).
| |
-|  | Update source headers per new ASF header
policy Fixes [LOGCXX-155](https://issues.apache.org/jira/browse/LOGCXX-155).
| |
+|  | make install fails since \@manual_dest@
replacement is missing in Makefiles Fixes
[LOGCXX-157](https://issues.apache.org/jira/browse/LOGCXX-157).
| |
+|  | immediate flush in console appender Fixes
[LOGCXX-156](https://issues.apache.org/jira/browse/LOGCXX-156).
| |
+|  | Update source headers per new ASF header
policy Fixes [LOGCXX-155](https://issues.apache.org/jira/browse/LOGCXX-155).
| |
|  | Automate log4cxx site and doxygen generation
and deployment Fixes
[LOGCXX-153](https://issues.apache.org/jira/browse/LOGCXX-153).
| |
|  | gcc warning about cast from \`const void\*'
to \`log4cxx::helpers::Object\*' discards qualifiers from pointer target typ
Fixes [LOGCXX-152](https://issues.apache.org/jira/browse/LOGCXX-152). | |
|  | Umlauts as literal in patternlayout won't be
logged correct Fixes
[LOGCXX-151](https://issues.apache.org/jira/browse/LOGCXX-151).
| |
